From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbdJCIgF (ORCPT ); Tue, 3 Oct 2017 04:36:05 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:42388 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbdJCIgB (ORCPT ); Tue, 3 Oct 2017 04:36:01 -0400 X-AuditID: b6c32a49-99fff7000000104d-77-59d34bee3308 Subject: Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position To: Bart Van Assche , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "subhashj@codeaurora.org" , "martin.petersen@oracle.com" , "vinholikatti@gmail.com" From: Alim Akhtar Message-ID: <5131c130-cae7-232b-1694-5669348bb724@samsung.com> Date: Tue, 3 Oct 2017 13:58:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1506962493.3368.35.camel@wdc.com> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsWy7bCmpu4778uRBt0rdCwu/fnCaHF51xw2 i+7rO9gslh//x2RxY/FONosdC6sc2Dwu9/UyeeycdZfd4+PTWywenzfJebQf6GYKYI3isklJ zcksSy3St0vgyrj7qoW54B57xdGXv9kbGFvZuhg5OSQETCS+PjzP3sXIxSEksJtRYuKTv2wQ zidGiZbDlxghnG+MEkuenmOEafnz4QpUYi+jxPr1HcwQzltGidbLp5hAqoQFvCU2zjjOCpIQ EVjFKPF/30JWkASzwEpGiaVtmiA2m4C2xN3pW8AaeAXsJN7e3McOYrMIqEjsu/cCLC4qECFx YdNPqBpBiZMzn7CA2JwC+hJ3Hz9gh5gpLnHryXwmCFteYvvbOWAXSQjcZ5M4/+8e1N0uEnP3 X2CBsIUlXh3fwg5hS0m87G+Dsssl2q/+g2ruYJQ4NekcVIO9xIErc4BsDqANmhLrd+lDhG0l Dt/vZoFYzCfR+/sJE0iJhACvREebEESJqkTzu6tQUzwkprauh7IdJR5+usk2gVFxFpLXZiF5 ZxaSd2YhLF7AyLKKUTK1oDg3PbXYtMAwL7Vcrzgxt7g0L10vOT93EyM4AWl57mCcdc7nEKMA B6MSD2+C26VIIdbEsuLK3EOMEhzMSiK807wuRwrxpiRWVqUW5ccXleakFh9ilOZgURLnPbaz NFJIID2xJDU7NbUgtQgmy8TBKdXAWF0szyXqJtT89DajeZuLFPvOY9cNtXY8nC3apZX5wWj1 3bUyrN0PHN6KbZkieNZcaeGJhtXvu1a4RK8/2JJZ9MG5srMqQWazk7gv89Y7e8q6/kX9+/dD +fudBQY9W8QamTZVS+gK9D4O830ls+67vsesqZxqaXqGk0pXCDPPCI7KerRUROK5EktxRqKh FnNRcSIAgKnvPDwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsWy7bCSnO5b78uRBq/f2Vhc+vOF0eLyrjls Ft3Xd7BZLD/+j8nixuKdbBY7FlY5sHlc7utl8tg56y67x8ent1g8Pm+S82g/0M0UwBrFZZOS mpNZllqkb5fAlXH3VQtzwT32iqMvf7M3MLaydTFyckgImEj8+XCFsYuRi0NIYDejxKv9V9gh EtIS1zdOgLKFJVb+e84OUfSaUeLwjKuMIAlhAW+JjTOOs4IkRARWMUr0dh8EG8UssJJR4tLH vywgVUICBxglunf4gthsAtoSd6dvYQKxeQXsJN7e3Ae2gkVARWLfvRdAcQ4OUYEIiQ0b+SFK BCVOznwCNoZTQF/i7uMHYOXMAmYS8zY/ZIawxSVuPZnPBGHLS2x/O4d5AqPQLCTts5C0zELS MgtJywJGllWMkqkFxbnpucWGBYZ5qeV6xYm5xaV56XrJ+bmbGMHRoqW5g/HykvhDjAIcjEo8 vAlulyKFWBPLiitzDzFKcDArifBO87ocKcSbklhZlVqUH19UmpNafIhRmoNFSZz3ad6xSCGB 9MSS1OzU1ILUIpgsEwenVANj7bqStc/1895XT/nvwLl2woF92QaZ+2LPdhtITAxexnzwyB65 Un7fuNOcCTkiKevrz3WtfSZ6+65Us0DBovltbyWjM9ffWib5qVz58Zs1SraVVe6SazhPyhar nGvNkk0NEVpzj+upXPc3K6fJ/Ho2M3gO7RVfYqamLR5fkznn0VseuQq+j6JKLMUZiYZazEXF iQD4/RGvkgIAAA== X-CMS-MailID: 20171003083558epcas5p2500a5254844ca807bbebe931a9c4bd8b X-Msg-Generator: CA X-Sender-IP: 182.195.40.13 X-Local-Sender: =?UTF-8?B?7JWM66a8G1NTSVItRkRTIFNXG+yCvOyEseyghOyekBsuL1Nl?= =?UTF-8?B?bmlvciBDaGllZiBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QUxJTSBBS0hUQVIbU1NJUi1GRFMgU1cbU2Ftc3VuZyBFbGVj?= =?UTF-8?B?dHJvbmljcxsuL1NlbmlvciBDaGllZiBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= Content-Type: text/plain; charset="utf-8" X-MTR: 20171003083558epcas5p2500a5254844ca807bbebe931a9c4bd8b CMS-TYPE: 105P X-CMS-RootMailID: 20170930062956epcas1p1461ea07e21a275a9e5733b3b90b5896a X-RootMTR: 20170930062956epcas1p1461ea07e21a275a9e5733b3b90b5896a References: <1506752526-27014-1-git-send-email-alim.akhtar@samsung.com> <1506962493.3368.35.camel@wdc.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bart, On 10/02/2017 10:11 PM, Bart Van Assche wrote: > On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote: >> Currently UFS HCI uses UFS_BIT() macro to get various bit >> position for the hardware registers status bits. Which makes >> code longer instead of shorter. This macro does not improve >> code readability as well. >> Lets re-write these macro definition with the actual bit position. > > Can the three patches in this series be combined into a single patch? > Since UFS_BIT() used in qcom-ufs driver as well, so I thought of keeping them in separate patches. This way "git bisect" will work all the time. >> -#define UFS_BIT(x) (1L << (x)) >> [ ... ] >> +#define UFS_BIT(x) (1L << (x)) > > If you want to keep the three patches separate, please make sure that this > patch does not modify the UFS_BIT() definition. Please also fix the spelling > of the title of this patch (marco -> macro). > Ok, will fix these > Thanks, > > Bart. >