From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCE733C3437 for ; Fri, 31 Jul 2026 11:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495712; cv=none; b=uCodcwIgN7srhuvoFugCkqx5umWka85HF7JeOAU9uGGKQ9PAEdaId+uI0fhEXsrtDHnXmVyWBKcrElQ+6rGvAKwdBF3Zb3BCNpx+Pk5b0bK5jWHkKFoMGh6LYolkF+p6FeDjw1hA+d2ZtVKUuhXzgxyoGYHnMsRpg5GIMtD9RT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495712; c=relaxed/simple; bh=lmIlcCPPjfy2tKJPCB5IOMJRdhikECabt3KeCbjuI/Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NnnyOL0mznHwEhT7ES+/chqpfQWpkpasimnffT2C1SE6Qtl879Q6kouYg1LDDAuaEsz8LPvrVsiokb43sbpV+LPB6b7cWGOoHjYyh3tUFyxEx7j4gBJ5n206uY7dgkigjAlUQ17sBsZPgWhwl5MiwdMtC1ZSuU7UAZXQS8Qd9OQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lCjgIpdZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kCVnF4iv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lCjgIpdZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kCVnF4iv" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VAeOU53575146 for ; Fri, 31 Jul 2026 11:01:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r3e/L0q20ll9U/xUZgEVMkmMsHsy5Op3pRyml4PevRM=; b=lCjgIpdZcmcNs1At x/QtXAQXR6yzNjOyJomb2I278fGaQwH3bzcBlaBRTfNdaF/7ZwbEZBDZGhjDBLWZ qovyqMwZxZNo5RysjYqeldd0LedeeQZjb4WHbxBFzmCDz7thhKsGeFivfFcKIWnH GxWhTdtpRGrdJoYiC89q+PXV32Fl1kGu6vQtl2Bi9q6hafWkV0rBJWJmPBcU0ovx sokW7u6kQ5+7nkYWaV8MUGyNbu0zWcx91It9yFHVAhySG9N8kthT7jDNBWCL7fms LLJgOZ5uXVmUFqWdL02Iepk2q87TyVw0KXH6gFgwP+yzJgRyJBDz6LLaTJXJZVfM aNVETA== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frt5mg2cm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 11:01:50 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-737ddaf8c57so23874137.0 for ; Fri, 31 Jul 2026 04:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785495710; x=1786100510; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r3e/L0q20ll9U/xUZgEVMkmMsHsy5Op3pRyml4PevRM=; b=kCVnF4ivgp6TxPhzA4H+UIgRbR6hAU4xtv1Ud/UhfRIlIf4NP88zbbBjWvOZ9KKclX D1gxlDCp76Sk7+G5oZ2gJj63lnaHraTrEbjHHeXXxxuLsslXPmbAXy08+ULurM0aJzXX RvFEKKlYYx5TBnUteczZn88mD6c9VdQMio6VUGNkpEntxlIeEuJ97wiwzbArUSCvWwmK gWEt8R0n6zaGhK5+dqidJ818grHgB+mGijwVi6M/h7WWVzmFYP4BXr/j2MXrC3ofOyX5 kbx6ekQAOWaqtrGQk41pFKCvWdYRYK+lm+6nvmFeSdFzodjYDH62uOOhNw30UFk+M5+a ImUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785495710; x=1786100510; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r3e/L0q20ll9U/xUZgEVMkmMsHsy5Op3pRyml4PevRM=; b=YyH7SDnBXwChzdBAS811fqAy/Wr4zDZ8XM4Th/NFmMK/953H/xVHnZSCdG/KDO73MU YsXUYUvoqjYiipjD6qChtyRm8e5BYNREieF9WyPdk+Ystb4fN6H1bZDeG1kFFyGX4idd VKpT4nYk2TQuQUg8Vh1w+rgrJNN1QVODRvLit+wQAq2OW6cyTXEsHGD9EqyvYNL4omLF AZGki7GL1NIlWVQjg20N+X1EaiDfuwtmSP1GRG3cze4WfX5e8egptZjpnvHByvjXG8nq 3lMFaVEtQnf4Iu+IImLnJXiRHoJF2PmLCwXonShYFcTgSAejSDGqz4l5wqktECB4Xhsh RAAg== X-Forwarded-Encrypted: i=1; AHgh+RosEif2gLEhMLzab82eEMO3nduJ/kAvpz2F798fI8O+IJuI8OeM6HDirQTfxmtboturJgI+RGLLxjIldlE=@vger.kernel.org X-Gm-Message-State: AOJu0YwPk+mNcUAFb3ZM7DrvA1ipvmIeG+Zgh1Nyz5pU1tgG2XTx74tP 0g+L/Gtz/5sljDrrongrA5uQeMjcBmW0/93QVSK2ITNYEV+yzHw7ULR/mbranFEZL286RBIothn qcvLxX+5orgonU5MClq0SZUseB4m4ezM4wNVSkTmCqclEPUBsGKWB/AXCCy2W7TepI7o= X-Gm-Gg: AR+sD137dESMsCipUgnzAi720bxK05f+6fKK81nzPMz1sghwSi6syEhVEV6kUMSbq8Z OT+svx2ro/o3kud8VIl6yhMd9HSib+gwpcGqZxrd62co8TueQWOF/Zzavcu3et7/RYP0Wn4p+KJ 87wXE0tge47fTWguyfTPdj3/bxQcOh/gH3GV9Ck2nBECG97Q3n1KR+muP/QapA0HgILf2kbvUHW tVDsdOVjcCaiTgos4hrWLrjWiFCP7vFBW5H6ckSlH4dyY8YMItxAp/kbjQ1gt94WTGKtHXL88MG mFJz0N42nVcFHk2SIf4OhDkRA9PL+lW6WEwZ/DXsO4VZM9r/CgQfowgGQhatP1VIFEkbARoXhIN f+XVIysGLOIw1/6gN6CWX78gf X-Received: by 2002:a05:6102:b0f:b0:74a:b1ee:e21b with SMTP id ada2fe7eead31-758f91821bamr297301137.1.1785495709752; Fri, 31 Jul 2026 04:01:49 -0700 (PDT) X-Received: by 2002:a05:6102:b0f:b0:74a:b1ee:e21b with SMTP id ada2fe7eead31-758f91821bamr297235137.1.1785495709311; Fri, 31 Jul 2026 04:01:49 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c5b387sm111840566b.2.2026.07.31.04.01.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 04:01:47 -0700 (PDT) Message-ID: <51346b78-3fd8-4426-a7ce-fb46052c591a@oss.qualcomm.com> Date: Fri, 31 Jul 2026 13:01:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] usb: xhci: Honor PORTSC.TM if valid To: Mathias Nyman , Konrad Dybcio , Thinh Nguyen , Greg Kroah-Hartman , Mathias Nyman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, usb4-upstream@oss.qualcomm.com, Raghavendra Thoorpu , Mika Westerberg References: <20260715-topic-dwc3_tunneling_state-v2-0-026487a08119@oss.qualcomm.com> <20260715-topic-dwc3_tunneling_state-v2-2-026487a08119@oss.qualcomm.com> <7f0618ed-d2da-42a1-a605-0660439255d7@linux.intel.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7f0618ed-d2da-42a1-a605-0660439255d7@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: rZQMkbcmbRs4010GUsOfuTAvkMi39iyk X-Authority-Analysis: v=2.4 cv=fsrsol4f c=1 sm=1 tr=0 ts=6a6c809e cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=T39ctT4NTyHGGofNco4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA4MyBTYWx0ZWRfX73xHCaelK03T kbfzy0dGa/NXZvF8eIs3a4S/buU/HNuzTv2oxShMOC8u6RzAUZcQq+2ts0uLRFRdfB2rbAvSOFu IPPJmaI7zxw6vTxhiYLj7rmb5Mrfs+8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA4MyBTYWx0ZWRfX2IptNGQeJwik 3SXcmMuSaBXvkmG9ESj1rZBHWT2N+uoKU9XXJhFClfayRvOXWRp4ZTFoUukITqRM4DLfrI8/ZGM Tnh1Yg3DrWHcANbo6qc3VnBtpFEkMlhi8yW8n0EcXIK47cRe7OSANKTsC8E910OZFxf4Vn/VPgE f+BZoPNURiT6ThTHKYSO8C0lQH3hyAUBioGza8s7EVtBFuyV6PJJGJsTrR6udoz1aMflK1wQbfR gO7dmy1XFIVf0GufXcWB83PDJ5WwbhDnoV9zC1N0o3gAEj407weTJWnlAp9T8c8haG7y/DIabo7 TeD4TYSDFDuYtkwBBYHtLCTpgoZlGpZZB7RzPuzI7D86b1EdmIHQMb53cjaN9RRe38O5y2A3McR dpCLKXxQxQgq2C/W3LdmUn9zo9VurBsfCnJ9dVlwjifLhLmc65iNslsjR753VwT+jK/ZPtS5QY7 qquLnjiq3nBlsBDWXFA== X-Proofpoint-GUID: rZQMkbcmbRs4010GUsOfuTAvkMi39iyk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 bulkscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310083 On 7/31/26 12:51 PM, Mathias Nyman wrote: > On 7/15/26 15:29, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> Currently, the only way for the USB core to determine whether the link >> is native or tunneled is via an Intel vendor-specific Extended >> Capability. [...] >>   -    /* Don't try and probe this capability for non-Intel hosts */ >> +    /* Prefer the XHCI v1.2 ext_cap if advertised */ >> +    offset = xhci_find_next_ext_cap(base, 0, XHCI_EXT_CAPS_USB3_TUNNELING); >> +    if (offset) { >> +        if (!(readl(base + offset) & XHCI_USB3_TUNNELING_SUPPORTED)) >> +            return USB_LINK_NATIVE; >> + > > The extcap 18 value won't change. > We can read it once in xhci_gen_setup()/xhci_setup_port_arrays() and cache it. > > here we would just check: > > if  (xhci->portsc_tunnel_reporting) { >     ..read portsc and return, as you do below Got it Konrad