From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932566Ab3CDXuZ (ORCPT ); Mon, 4 Mar 2013 18:50:25 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:59536 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758337Ab3CDXuX (ORCPT ); Mon, 4 Mar 2013 18:50:23 -0500 X-IronPort-AV: E=Sophos;i="4.84,783,1355126400"; d="scan'208";a="27660642" Message-ID: <5135333E.6030305@codeaurora.org> Date: Mon, 04 Mar 2013 15:50:22 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Mark Rutland CC: Paul Mundt , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , Russell King , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 8/8] ARM: smp: Remove local timer API References: <1361518039-16663-1-git-send-email-sboyd@codeaurora.org> <1361518039-16663-9-git-send-email-sboyd@codeaurora.org> <20130222111545.GA15020@e106331-lin.cambridge.arm.com> <20130222162458.GA19670@linux-sh.org> <20130225134041.GA22785@e106331-lin.cambridge.arm.com> In-Reply-To: <20130225134041.GA22785@e106331-lin.cambridge.arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/13 05:40, Mark Rutland wrote: > I've had a quick go at writing a generic timer driver. I've not had a chance to > test it, and there are a couple of things that are up for discussion (e.g. what > should the rating be) but I think we want something very close to this. > This looks good to me. I only have some minor comments. What's the plan for merging? Get tglx to take this and provide a stable branch and then base my patches off that and get these patches taken through arm-soc? > diff --git a/drivers/clocksource/dummy_timer.c b/drivers/clocksource/dummy_timer.c > new file mode 100644 > index 0000000..bdaba34 > --- /dev/null > +++ b/drivers/clocksource/dummy_timer.c > @@ -0,0 +1,67 @@ > +/* > + * linux/drivers/clocksource/dummy_timer.c > + * > + * Copyright (C) 2013 ARM Ltd. > + * All Rights Reserved > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > +#include > +#include > +#include > +#include > + > +DEFINE_PER_CPU(struct clock_event_device, dummy_evt); static? > + > +static void dummy_set_mode(enum clock_event_mode mode, > + struct clock_event_device *evt) > +{ > + /* > + * Core clockevents code will call this when exchanging timer devices. > + * We don't need to do anything here. > + */ > +} > + > +static void __cpuinit dummy_setup(void) > +{ > + int cpu = smp_processor_id(); > + struct clock_event_device *evt = &per_cpu(dummy_evt, cpu); Can we use __this_cpu_ptr()? I wonder if that makes the code generation better or worse. I didn't do it in my 8/8 patch because I wanted the code to be the same before and after to show code movement. > + > + evt->name = "dummy timer"; > + evt->features = CLOCK_EVT_FEAT_PERIODIC | > + CLOCK_EVT_FEAT_ONESHOT | > + CLOCK_EVT_FEAT_DUMMY; > + evt->rating = 100; > + evt->set_mode = dummy_set_mode; > + evt->cpumask = cpumask_of(cpu); > + > + clockevents_register_device(evt); > +} > + > +static int __cpuinit dummy_cpu_notify(struct notifier_block *self, > + unsigned long action, void *hcpu) > +{ > + if ((action & ~CPU_TASKS_FROZEN) == CPU_STARTING) > + dummy_setup(); There are already two dummy_setup() functions. Perhaps we can s/dummy/dummy_broadcast/ throughout this file? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation