From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA062283129 for ; Fri, 31 Oct 2025 13:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761916794; cv=none; b=ItGoaubro9+ldcfU/cBr0tc6wOnIUmZ1GnjOW6t3SowNK75HQ0JP59PaEpqhMSihRerVGLfU+yUsEFcX9ITq7J1H30n0QwjWxTnPIgVPM3FbDd+3Gsh3sXARRqWaZJNnXPOMK5ZzBbHEvS54Q8NBsR6Y+jsL3kLzC5tptGxh3/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761916794; c=relaxed/simple; bh=kKIlQC49+1HvPMZ+KSY6IKOFV0Kf/+b+20LKz34U5yw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kwzsPh14qzUFwze8F/Htd7AWa3PnVhxB+41W4k4B/w4EtcB5TCaqkHWZnqEqZfL7YzW5evNbFGP5BU4T+dWXoDSx+Xcjo5dn8RQCJOUkXrYZM5q5JqklBGrNZ87FHaA7gU57wCUJX7CIH57n9P2wAElRpnDznFwQU0cxJT8wRJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZWXDynPN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K1pjdOwM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZWXDynPN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K1pjdOwM" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59V9jO4q2471151 for ; Fri, 31 Oct 2025 13:19:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=i1q+8kjbF6ZsBZxOZVi0iNgl M800iA6/f1hi233PBSY=; b=ZWXDynPNwl8wiZazuA3y2ocv1d/aLxaGDtl82VqZ EJtTz1fL6bsdzJbYiIqWIE1t1WEnaqsBLM4jIlbwx+DVvIotP/zdEwBmxc0MBiWH 2beK8WTOw/gZHacDNqEBkRLhP0vh827gI4xjjHsLYghT5UXV0gOl2mprGb2+VcUK 3l1H56sAOQxuCeCsNuOKEX+dntEu6GDfnWRoFcWsDDeV1w7CtdHkF0Xc85wwckKK cQt0GI+bDoA1odYCOjt7l6ifAtK3UwFmViJU1/w34KixwQV5tTy/fQGIxiubqos9 2Li5JhKwouut+803Y1zYcoILNaRgKZ8kfYwjTu9jhuaPLQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a4trv0h1h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Oct 2025 13:19:51 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-295395cedafso4690575ad.1 for ; Fri, 31 Oct 2025 06:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761916791; x=1762521591; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i1q+8kjbF6ZsBZxOZVi0iNglM800iA6/f1hi233PBSY=; b=K1pjdOwMQmIt7MXhmjeKr0ZdOz6v2iQ+AQk5lDa8HoyIlTL787GjS8YEZfIssWt+l0 agpcljPoYoU2BnHu1qzlX0SieWeFp3MA6Lt82c5LR+ZypqjZ1pIz8/fDQ2m7aHsBcdim IZd6Q0/ZHSVUCdc2aOPncyUGtiAcZxNCbWmhqbIiq6QLZreaztpghxUjLadyQphzAxfW 7Kf/bWHNHcXGzWHoL9V8fyntbw+3ezhBUcpwAl1NMne6RMl4IEOh7qk3R6FMzcga9xrH cVwe8wVY9hEL3Jn9a1tK6HVDFq4+KHxf4CkfK4utS+OyUAwwrZUOQbGG6IvZsNTf+oQj 4bng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761916791; x=1762521591; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i1q+8kjbF6ZsBZxOZVi0iNglM800iA6/f1hi233PBSY=; b=mul+4cLpDaQGP9Zjce3NzpWj46jpEZko7sCEtGeFwMf2Ntn1oG3ymH0DILKCK0svk/ vGoXaGpDU2W7NYk/O9VHPP9pI72fo3Aq1tWDFqp12WnKUBrdpTK4z/aAm3acoeA2jQ+Y jagKsDGGVu0/WqZ1zs6ZZOtx7YRPq229EvkrqkTLYMsUW14E3pvJVeLmuphAtdFDJmze bHdPwJDUwZAtvs+ePKWWLmsejgkYNyUxkOk5mjDpJ04QqO0TT2rg9nNoOg0+DH/4kfUC k5YWCphkpMj+1xwVlVdsGkZcw0uINJMeiVShaAwE/guCrvn/dAFkx2CZV1CszKay8173 vCGw== X-Forwarded-Encrypted: i=1; AJvYcCXmRQFjH3YYAKKIoaODF83QCVlkio/RmlyMOjcsExoExcRy4b7a/lvBXgsZVJLzQjmKzgV7vxg8RocfAYA=@vger.kernel.org X-Gm-Message-State: AOJu0YzF0H/Hl701qi0UKE/gRGwwJDSWlbbLlRUF1u8eCadriJDXEUsJ IHEFH7bfzFtgQZStYOmnTIC0SJhj3oM3/kXTsH+p5A5z6tOAEbxZV6nYQG71J+vWqCsSumQtXvQ txXbJrHxAMrABjl/2cAjn1gxS2SQI6rh5Z7xiy0onzxMmNMeqyXOK0eckTn4UtW1zpcU= X-Gm-Gg: ASbGncvNRJn6isx3eNsKthiWUzMRpRpc3paUAu6PpbUaaZobLXTF3uL+db04u9h0Flj DfLvMARjVtJNMnG0ePI4D/rXWfE01MId2L2V8ANUYxY3a4C8os+uFsCtqKVn3wxX8xIm529Q8zP OF5xCJMBMdWqyFq9JuoesTUedkjHYfaFJwoSJYb/092QfjSMTZtbp2R7vezjU7uWSMjz2V0koYa QFqnOex7+S1YoAYAh8kBmMreZix/NllaBWg1UVDsU45bcQcy/3yj05vfFROVNR3hNL4atuirJRx S00SlMfX7TmwZuqh00DY6hMWSdd2fB7FqaifEKv6re7hrALrc2wEsuN5RecEcFTFbmhUAMtcj0c vr0CwjOrPtgnsmUCmj0JpS2nDI891O9DW X-Received: by 2002:a17:902:f544:b0:290:a70e:6261 with SMTP id d9443c01a7336-2951a361f70mr55559755ad.11.1761916791084; Fri, 31 Oct 2025 06:19:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWz7WaGspHmY6hwyIZRpl6IwBTpTBuIV69EQKKehTnyEv9Oq+hWYVVrkE1+HxBN8oUAGfLBg== X-Received: by 2002:a17:902:f544:b0:290:a70e:6261 with SMTP id d9443c01a7336-2951a361f70mr55559015ad.11.1761916790332; Fri, 31 Oct 2025 06:19:50 -0700 (PDT) Received: from hu-pkondeti-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2952696df55sm24405685ad.70.2025.10.31.06.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 06:19:50 -0700 (PDT) Date: Fri, 31 Oct 2025 18:49:43 +0530 From: Pavan Kondeti To: Krzysztof Kozlowski Cc: Pavan Kondeti , hrishabh.rajput@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Dmitry Baryshkov Subject: Re: [PATCH v4 2/2] watchdog: Add driver for Gunyah Watchdog Message-ID: <51372234-0fd8-4cee-a296-a5e8626b52a8@quicinc.com> References: <20251031-gunyah_watchdog-v4-0-7abb1ee11315@oss.qualcomm.com> <20251031-gunyah_watchdog-v4-2-7abb1ee11315@oss.qualcomm.com> <13d2963d-e931-4e51-b875-a1650b899bb7@kernel.org> <09e8485f-f512-4069-be9f-3e94fb142aa3@quicinc.com> <68b2b40a-da98-46b8-bf48-ce17fb3b79cd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68b2b40a-da98-46b8-bf48-ce17fb3b79cd@kernel.org> X-Proofpoint-ORIG-GUID: dbkZ1GVLL5zafJtvLt4R96wDXEBZBhea X-Proofpoint-GUID: dbkZ1GVLL5zafJtvLt4R96wDXEBZBhea X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDMxMDExOSBTYWx0ZWRfX+UqulB5Ev+YE 6WSeTWx43+2Kiq4sEKRIBw/HelRe/z2PLagSVSMJyLMWulU0UR36IIPUrVSEn3qJDQ8LByKjh0g Ddn0yXOT1jTtAWG7VRd3uRA8eUYGLO2oyhmdrRt94vMJEIDrKou9R9zGlk9DckFYblzlDkxuPT9 +nVPDV1UwhPg85WRSF/QHoo07WEP/5HzQsqZosTCMRQFiPbeXkXbMS1X+m8vuP9+6sghIOel7hW 94uitPfs3zqvHRlEWtKwOSBRjmKSa4dpRxO68CC7IlwPUSSXw04kjccnSdH5nevSZ3mVD0G7Ju3 Vo44cxRWBlThOabWmuHSUq70tzuNyvuMlikArp2kNlTrW1zRfgxeSvHTDd0dOripjVQA+KjbRtC ArVF+5oBCzN9NZjGGAtvcI48Cy63Iw== X-Authority-Analysis: v=2.4 cv=XoP3+FF9 c=1 sm=1 tr=0 ts=6904b777 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=1ZP6r6y3UWDVpadotx8A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-10-31_04,2025-10-29_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510310119 On Fri, Oct 31, 2025 at 01:39:11PM +0100, Krzysztof Kozlowski wrote: > On 31/10/2025 13:11, Pavan Kondeti wrote: > > On Fri, Oct 31, 2025 at 12:48:18PM +0100, Krzysztof Kozlowski wrote: > >> On 31/10/2025 11:18, Hrishabh Rajput via B4 Relay wrote: > >>> + > >>> +static DEFINE_SIMPLE_DEV_PM_OPS(gunyah_wdt_pm_ops, gunyah_wdt_suspend, gunyah_wdt_resume); > >>> + > >>> +static struct platform_driver gunyah_wdt_driver = { > >>> + .probe = gunyah_wdt_probe, > >>> + .driver = { > >>> + .name = "gunyah-wdt", > >>> + .pm = pm_sleep_ptr(&gunyah_wdt_pm_ops), > >>> + }, > >>> +}; > >>> + > >>> +static int __init gunyah_wdt_init(void) > >>> +{ > >>> + return platform_driver_register(&gunyah_wdt_driver); > >>> +} > >>> + > >>> +module_init(gunyah_wdt_init); > >> > >> > >> Heh, what was my last message? If I see module_init() I will NAK it. > >> > >> At v3 you really ignored entire feedback and this one here continues the > >> pattern. > >> > >> NAK, please read how Linux driver model is works. > > > > You mentioned in your previous reply that > > > > ``` > > If you call any module_init other than module_foo_driver I will keep > > NAKing your patch because it is wrong. I explained why wrong already > > multiple times in previous threads and other discussions. > > ``` > > > > If you are referring to why module_platform_driver() is not called here, > > Hrishabh answered that already previously. Please see > > https://lore.kernel.org/all/ndwwddd7vzjpgvzg55whdno4ondfxvyg25p2jbdsvy4lmzsfyy@jnn3wywc7xtp/ > > > > > Your commit msg does not explain why this cannot be unloaded. What you > want - intended to be a persistent module - is not relevant here. I want > it to be a proper and regular driver module and I said it last time. > Thanks for the feedback. I am happy that the only concern you have is about unloading the module :-) I feel that is the easiest problems so far have been pointed out. Hrishabh, I belive we can disable watchdog via SMC interface. To make a proper and regular driver module like Krzysztof is asking, we can make it module_platform_driver by implementing remove method. Thanks, Pavan