From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961AbcEPRMj (ORCPT ); Mon, 16 May 2016 13:12:39 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:34337 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753399AbcEPRMh (ORCPT ); Mon, 16 May 2016 13:12:37 -0400 Subject: Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware To: Mario Limonciello , ming.lei@canonical.com References: <1463413264-32500-1-git-send-email-mario_limonciello@dell.com> Cc: LKML From: Laura Abbott Message-ID: <5137db8c-644e-3306-882c-cc820394cbce@redhat.com> Date: Mon, 16 May 2016 10:12:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463413264-32500-1-git-send-email-mario_limonciello@dell.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2016 08:41 AM, Mario Limonciello wrote: > dell_rbu previously would allow a userspace application to craft the > payload after dell_rbu was loaded and abuse the udev userspace API. > > Instead require the payload to be crafted and placed in > /lib/firmware/dell_rbu ahead of time. > > This adjusts dell_rbu to immediately load the firmware from > /lib/firmware/dell_rbu when "init" is passed into image_type using the > kernel helper. Looks like you missed the Signed-off-by line. Can you also drop the Kconfig dependency on CONFIG_FW_LOADER_USER_HELPER? Thanks, Laura > --- > drivers/firmware/dell_rbu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c > index d5f5b98..5ecf043 100644 > --- a/drivers/firmware/dell_rbu.c > +++ b/drivers/firmware/dell_rbu.c > @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, struct kobject *kobj, > if (!rbu_data.entry_created) { > spin_unlock(&rbu_data.lock); > req_firm_rc = request_firmware_nowait(THIS_MODULE, > - FW_ACTION_NOHOTPLUG, > + FW_ACTION_HOTPLUG, > "dell_rbu", > &rbu_device->dev, > GFP_KERNEL, >