From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753291AbbJFVC4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Oct 2015 17:02:56 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:53818 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753203AbbJFVCv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Oct 2015 17:02:51 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Gabriel Fernandez <gabriel.fernandez@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
        Maxime Coquelin <maxime.coquelin@st.com>,
        Patrice Chotard <patrice.chotard@st.com>,
        Russell King <linux@arm.linux.org.uk>,
        Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jg1.han@samsung.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Fabrice Gasnier <fabrice.gasnier@st.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        " David S. Miller" <davem@davemloft.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Joe Perches <joe@perches.com>, Tejun Heo <tj@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Thierry Reding <treding@nvidia.com>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        Minghuan Lian <Minghuan.Lian@freescale.com>,
        Tanmay Inamdar <tinamdar@apm.com>, m-karicheri2@ti.com,
        Sachin Kamat <sachin.kamat@samsung.com>, Andrew Lunn <andrew@lunn.ch>,
        Liviu Dudau <liviu.dudau@arm.com>, Zhou Wang <wangzhou1@hisilicon.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, kernel@stlinux.com,
        linux-pci@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v5 3/3] PCI: st: Provide support for the sti PCIe controller
Date: Tue, 06 Oct 2015 23:01:11 +0200
Message-ID: <5139149.TmJY1YjqAU@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1444118168-13086-4-git-send-email-gabriel.fernandez@linaro.org>
References: <1444118168-13086-1-git-send-email-gabriel.fernandez@linaro.org> <1444118168-13086-4-git-send-email-gabriel.fernandez@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:XqQNg57InL16XtuTIABL9xVULqGA7xKENCEx+9Or7g2gIpk4QB1
 vUDw8mOIf29al3HM0lb0Bw3npYg1WGRB+JlYG58FqFa8nHhurpfrH3j0lW2yJDXOrgk29WR
 cyFLhz40TyZ+dOlWql+EazU6af6KYlv6U7wykwY5we8jLsaGIKQ2MJx/4ks47tcIbkhvkHs
 BXXi4uXB/5yR5PyGTx2+w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:rV8hIEdTqVk=:boJOYfafkivsw6tFLZNOtW
 ZmUck7DIArEnTMskJUuvXP4yxbWlL5HtxRQNJt7vYBNtazp1yuoxG7VyYMH/SYeG3TZzIw1FJ
 6M7Y5WHAFOeMBhjv1LV3jo1N2nr37Pt1r7f55DRAyvH2iFXRo/5c0KFymBbPpUCGlEzvSjM5u
 YkUArOzyt/1eGTBSzIk4a4EkBWMjuc0MGYLsYtY45op0kdR/YsIqFnI39cnYDCMws5iYuLhOX
 UXICNzK4B/35DGNSPBnBa4InIznqVQoOFlKqRqtCrKyvwBz2sHd5gnxP3hqcBr+d6+Pukdlda
 eMvlqu2ddgZPeNbO2jjhnMR1WUZwO53PgWLKNiO5EKDVPkP3e5OGr8nQ5X8yK0oNiU59wNFS0
 +KkIyP0tHQ4ZGDjrgOJp0+xrv+KCP9Vi3i7HR2amayvimXzQ0vJ5QL40o4Lz6uf0kshqyGTh7
 rilJc1gA3d+ZXab2EtRrqfJLNigfvrigP/AnKlUPcELUkIdjO+rSBMBQw5QlRwfBQEoxk7ikO
 J7/lHmOp87zqvEqAQ/to6GW6dAM3QZopOtlGHqv50oiIsFBPDZ7PyVwe1PmM3grt+wl5FU0Z5
 4zLXcEya+qoSlmF9dYrn8l0ObJw5OCQTbdgKTMqVgDBQDAsANiNwRnrVZKLn6cN3o1+mIhMHg
 p6EaNMWIGWGLy1gDOX/TDpGMooth9VvygCMN1kxzNTGVInnrkZ+AjrJZYtd6xbtIInk5kDeP3
 vZJZ7AsF8v2j2l65
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 06 October 2015 09:56:08 Gabriel Fernandez wrote:
> +
> +/*
> + * On ARM platforms, we actually get a bus error returned when the PCIe IP
> + * returns a UR or CRS instead of an OK.
> + */
> +static int st_pcie_abort_handler(unsigned long addr, unsigned int fsr,
> +                                struct pt_regs *regs)
> +{
> +       return 0;
> +}
> 

I'm not sure if we discussed this already for this driver. Usually
you should have a register in the PCI host that you can check to see
what caused the abort.

Try to make this as narrow as possible so you return nonzero for
any abort except the one you actually try to prevent.

	Arnd