mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Cc: James Hogan <james.hogan@imgtec.com>,
	<linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH 1/1] irq_work.h: fix warning when CONFIG_IRQ_WORK=n
Date: Fri, 8 Mar 2013 11:42:50 +0000	[thread overview]
Message-ID: <5139CEBA.7010704@imgtec.com> (raw)
In-Reply-To: <1362742582-26327-1-git-send-email-james.hogan@imgtec.com>

On 08/03/13 11:36, James Hogan wrote:
> A randconfig caught repeated compiler warnings when CONFIG_IRQ_WORK=n
> due to the definition of a non-inline static function in
> <linux/irq_work.h>:
> 
> include/linux/irq_work.h +40 : warning: 'irq_work_needs_cpu' defined but not used

In addition to this warning I also got the following linker error when
CONFIG_IRQ_WORK=n:

kernel/built-in.o In function `wake_up_klogd':
(.text.wake_up_klogd+0xb4): undefined reference to `irq_work_queue'

which appears to be because of the following commit:

commit 74876a98a87a115254b3a66a14b27320b7f0acaa ("printk: Wake up klogd
using irq_work") also merged in v3.9-rc1.

Can somebody more familiar with that code please fix it.

Cheers
James


  reply	other threads:[~2013-03-08 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 11:36 James Hogan
2013-03-08 11:42 ` James Hogan [this message]
2013-03-08 12:38   ` Frederic Weisbecker
2013-03-08 12:38 ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5139CEBA.7010704@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®