mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>, jaegeuk@kernel.org
Cc: chao@kernel.org, lihongbo22@huawei.com, sandeen@redhat.com,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, zhanxusheng@xiaomi.com,
	syzbot+e818dd42ada3b583bed1@syzkaller.appspotmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] f2fs: fix use-after-free of quota file names on failed remount
Date: Mon, 2 Nov 2026 09:34:25 +0800	[thread overview]
Message-ID: <513d4f4f-dd02-46b3-87c5-f95e9ff47a41@kernel.org> (raw)
In-Reply-To: <20261030072423.197883-1-zhanxusheng1024@gmail.com>

On 10/30/26 15:24, Zhan Xusheng wrote:
> From: Zhan Xusheng <zhanxusheng@xiaomi.com>
> 
> f2fs_show_options() prints the journalled quota file names without any
> lock that excludes remount, and a failed remount frees the current names
> before restoring the old ones.  Reading /proc/mounts at that moment is a
> use-after-free.
> 
> Read the names under rcu_read_lock() and free them only after a grace
> period.
> 
> Fixes: 4b2414d04e99 ("f2fs: support journalled quota")
> Reported-by: syzbot+e818dd42ada3b583bed1@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=e818dd42ada3b583bed1
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

      parent reply	other threads:[~2026-11-02  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30  7:24 Zhan Xusheng
2026-10-30  7:24 ` [PATCH 2/2] f2fs: free the quota file name that remount drops Zhan Xusheng
2026-11-02  1:38   ` Chao Yu
2026-11-02  1:56   ` Chao Yu
2026-11-02  1:34 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513d4f4f-dd02-46b3-87c5-f95e9ff47a41@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=lihongbo22@huawei.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+e818dd42ada3b583bed1@syzkaller.appspotmail.com \
    --cc=zhanxusheng1024@gmail.com \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®