mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	ming.lei@redhat.com, hch@lst.de, bvanassche@acm.org,
	axboe@kernel.dk, mpatocka@redhat.com, snitzer@redhat.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH 0/2] block: support to account io_ticks precisely
Date: Sat, 6 Apr 2024 15:57:14 +0800	[thread overview]
Message-ID: <513db882-ebe1-7287-99dd-3783c2c9b90f@huaweicloud.com> (raw)
In-Reply-To: <20240323035959.1397382-1-yukuai1@huaweicloud.com>

Hi, Jens!
Hi, Ming!
Hi, Christoph!
Hi, Bart!

Friendly ping ...

The 'util' reported by iostat is very important for users, they don't
have much choise to get disk status, while 'util' has been inaccurate
for a long time unnecessarily. I really think patch 1 is meaningful.

Patch 2 also tries to fix a problem by our customer that util can
sometimes be huge. The root cause is that 'inflight' is account from
blk_mq_start_request() while 'io_ticks' is account from
blk_account_io_start(), there is a gap. I let 'inflight' to be account
from blk_account_io_start() as well, please let me know if this is not
good.

Thanks!
Kuai

在 2024/03/23 11:59, Yu Kuai 写道:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Yu Kuai (2):
>    block: support to account io_ticks precisely
>    block: remove blk_mq_in_flight() and blk_mq_in_flight_rw()
> 
>   block/blk-core.c  |  9 +++++----
>   block/blk-merge.c |  2 ++
>   block/blk-mq.c    | 36 ++++--------------------------------
>   block/blk-mq.h    |  5 -----
>   block/blk.h       |  1 +
>   block/genhd.c     | 20 ++++----------------
>   6 files changed, 16 insertions(+), 57 deletions(-)
> 


  parent reply	other threads:[~2024-04-06  7:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23  3:59 Yu Kuai
2024-03-23  3:59 ` [PATCH 1/2] " Yu Kuai
2024-03-23  3:59 ` [PATCH 2/2] block: remove blk_mq_in_flight() and blk_mq_in_flight_rw() Yu Kuai
2024-03-23 16:05   ` Mike Snitzer
2024-03-24  2:11     ` Yu Kuai
2024-03-24 21:57       ` Mike Snitzer
2024-03-25  1:15         ` Yu Kuai
2024-03-23  3:59 ` [PATCH 0/2] block: support to account io_ticks precisely Yu Kuai
2024-03-23  4:08   ` Yu Kuai
2024-03-23  3:59 ` [PATCH 1/2] " Yu Kuai
2024-03-23  3:59 ` [PATCH 2/2] block: remove blk_mq_in_flight() and blk_mq_in_flight_rw() Yu Kuai
2024-04-06  7:57 ` Yu Kuai [this message]
2024-04-20  1:49   ` [PATCH 0/2] block: support to account io_ticks precisely Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513db882-ebe1-7287-99dd-3783c2c9b90f@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®