From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EBB20FA81 for ; Fri, 3 Jul 2026 01:45:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783043125; cv=none; b=XqA751914fKB4tnihhk3H2/mIl9CPW5pKkcrgtaVXMK9opd9bSfSMIdUL6Fyib1Es6v/DVhRGWRFTrDMvaHXyBvRO3H+a1zpuJ5SXMLud7Pl76l8xaBj7Vd8oqcfGU7tFU07+AVzehQ3e7k4TSVx+3tT7q6FDo/e3BSeKW3/Wto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783043125; c=relaxed/simple; bh=UYgFn2zdNJf7L2fcGSZgRBG1eF9vWZHaewtkLF0tkig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NSh6w6DLbkcfD4XfZhlACuXkWQY7EtK3bsRc9qH+tFMN5fl5wYFBeHfBEPv3ZwP5sCNiLW680jur0vT/EsTHOaq2CePIGyL/RoP7jKZwLXfQP+kuQ9V8Ya20aGmM5Hl6OmraU0qRuNBiWelXogW0ISwTacIx0kArWXTL4xiKW+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.198]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4grxPg1BMyzYQttC for ; Fri, 3 Jul 2026 09:44:23 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 4D39440589 for ; Fri, 3 Jul 2026 09:45:20 +0800 (CST) Received: from [10.166.163.161] (unknown [10.166.163.161]) by APP1 (Coremail) with UTF8SMTPA id cCh0CgB3S4gvFEdqY0alAg--.55757S2; Fri, 03 Jul 2026 09:45:20 +0800 (CST) Message-ID: <5140126d-ea86-4532-9ee3-33b98a064d1e@huaweicloud.com> Date: Fri, 3 Jul 2026 09:45:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs To: Marc Zyngier Cc: tglx@kernel.org, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260702033050.1583-1-shikemeng@huaweicloud.com> <20260702033050.1583-5-shikemeng@huaweicloud.com> <87h5mh6o1q.wl-maz@kernel.org> From: Kemeng Shi In-Reply-To: <87h5mh6o1q.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgB3S4gvFEdqY0alAg--.55757S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jr4rGFW3Xr1kKrW5uFW8tFb_yoWfZrXEy3 W0q3Z5Cwnrtw4xJF4Y9asFvF1DKay29r1DXFWjqF9rJryYyFn8G34qgrn5ZF48GF4qvrnx JasYqryY934I9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbz8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7CjxVAaw2AFwI0_JF0_Jw1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8V AvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUwzuWDUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ 在 2026/7/3 6:10:09, Marc Zyngier 写道: > On Thu, 02 Jul 2026 04:30:48 +0100, > Kemeng Shi wrote: >> >> Multiple ITS units may exist in a system. When an error occurs, it is >> difficult to identify which ITS triggered it because most error logs >> lack the ITS address. Some logs already include this information and >> is useful for debugging. Add the ITS address to the remaining error >> logs so that all ITS-related errors can be consistently attributed to >> a specific ITS instance. > > I already said *no* to this. > > If you want to log errors, implement a PMU or RAS driver that reports > errors on a per ITS basis, in a way that is collectable by existing > tooling. > > The kernel log is not the place for your sorry debug hacks, which is > in general not readable by normal users. And I'd rather remove the > other instances as a matter of consistency. > Will drop this in next version...> M. >