mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tommi Rantala <tommi.t.rantala@nokia.com>
To: Jon Maloy <jon.maloy@ericsson.com>,
	Ying Xue <ying.xue@windriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"tipc-discussion@lists.sourceforge.net" 
	<tipc-discussion@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: tipc_udp_send_msg oops in 4.4 when setting link tolerance
Date: Wed, 15 Nov 2017 11:42:15 +0200	[thread overview]
Message-ID: <5140a467-3493-752b-b7ba-a9e4c103f21d@nokia.com> (raw)
In-Reply-To: <AM4PR07MB1714EFBEC137F93E0562574F9A280@AM4PR07MB1714.eurprd07.prod.outlook.com>

On 14.11.2017 13:35, Jon Maloy wrote:
>> Found it, the missing patch is this one (9b3009604b8e does not help):
>>
>> commit d01332f1acacc0cb43a61f4244dd2b846d4cd585
>> Author: Richard Alpe <richard.alpe@ericsson.com>
>> Date:   Mon Feb 1 08:19:56 2016 +0100
>>
>>       tipc: fix link attribute propagation bug
>>
>>
>> It does not apply as-is to 4.4, so backported it, see below.
>> Does it look good? I can send it forward to Greg for inclusion in 4.4.
> 
> Yes. I would be very grateful if you do.

OK, sent the patch to stable@vger.kernel.org

>> But with this patch included, I can easily reproduce the "BUG: Bad page state
>> in process git" issue also in 4.4 like this:
>>
>> $ tipc link set tolerance 100 link $LINKNAME $ cd /tmp && git clone
>> /path/to/linux-stable
>>
>> I can try to debug that a bit more to see if I can figure it out.
> 
> I would appreciate that. If this turns out to also be an already fixed bug (most likely) you can send that directly to GKH too.
> If you find a bug that requires a new patch send it to tipc-discussion for review first.
> 
> Finally, I want to say that I very much appreciate users like you, who try solving the problems themselves and contribute to the code.
> We are right now in an upgrade phase of TIPC, where we have been/are adding new features to TIPC (overlapping ring neighbor monitoring, group communication, new addressing model, performance improvements...) which inevitably entail some new bugs, but I expect the frequency of these changes/improvements to TIPC go down in a few months, and with that the number of fixes needed.

Thanks!

After more testing, I noticed that I could only reproduce the "BUG: Bad 
page state" in a single machine, so maybe something wrong with the 
machine, and not with tipc.

-Tommi

      reply	other threads:[~2017-11-15  9:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 16:23 Tommi Rantala
2017-11-13 21:25 ` Jon Maloy
2017-11-14 10:15   ` Tommi Rantala
2017-11-14 11:35     ` Jon Maloy
2017-11-15  9:42       ` Tommi Rantala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5140a467-3493-752b-b7ba-a9e4c103f21d@nokia.com \
    --to=tommi.t.rantala@nokia.com \
    --cc=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®