From: Bart Van Assche <bvanassche@acm.org>
To: Yang Yang <yang.yang@vivo.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] block: fix deadlock between sd_remove & sd_release
Date: Tue, 23 Jul 2024 09:28:27 -0700 [thread overview]
Message-ID: <51421cc8-ef09-4d13-ae92-bc0839a8b3b3@acm.org> (raw)
In-Reply-To: <20240722091633.13128-1-yang.yang@vivo.com>
On 7/22/24 2:16 AM, Yang Yang wrote:
> SCSI does not set GD_OWNS_QUEUE, so QUEUE_FLAG_DYING is not set in
> this scenario. This is a classic ABBA deadlock. To fix the deadlock,
> make sure we don't try to acquire disk->open_mutex after freezing
> the queue.
>
> Signed-off-by: Yang Yang <yang.yang@vivo.com>
Fixes: and Cc: stable tags are missing. Otherwise this patch looks fine
to me, hence:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2024-07-23 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 9:16 Yang Yang
2024-07-23 1:33 ` Ming Lei
2024-07-23 16:28 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51421cc8-ef09-4d13-ae92-bc0839a8b3b3@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.yang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®