From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933723AbcAYQ5K (ORCPT ); Mon, 25 Jan 2016 11:57:10 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:53849 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932259AbcAYQ5F (ORCPT ); Mon, 25 Jan 2016 11:57:05 -0500 From: Arnd Bergmann To: Herbert Xu Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, "David S. Miller" , Chen-Yu Tsai , LABBE Corentin , Maxime Ripard , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] crypto: sunxi - don't print uninitialized data Date: Mon, 25 Jan 2016 17:56:40 +0100 Message-ID: <5143347.j0XTtrAXzs@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453740845-1980433-1-git-send-email-arnd@arndb.de> References: <1453740845-1980433-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:OoF33O3lLNroyASYioSQEHRAUst59F0/p53XNwMQ+XjZtkVDz18 F1jl2K/wi45ypg2dkJnnSTVaZjQJ4hGYECrXRs9xqkKdE248mWSnfC1PPNf/qdDqsnSDI3l QAEYy/iQ2veC55xCCCPXGRm/qAnzAOTxlmBRKpG+nbeWsala6hvfsLVnThL6sIJnVryooCB +RPu09CIzf6AvrcWtfV0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:9igtrpNVXH8=:ZkViGGxuLebzIEpKLkjLS0 bu1kQVec6JTkpSVvcgnX5PsRsP8QO61ockQKEb14nWUxFfB/pWk5wSMMLhrVmZADuFmenS8cY dplpSxShfs6r2xff88ZSOBb+DasrGMWeiXUJvfuFau3YFI7xfDos88YynQmccd90ywdpCEh89 UvTwHTvxDnKCYYmilgZnVO2BbQcJCmQEjllr1vMY/Rf2XGL0RlAZJrXCuer75LmutuAzKICVI 3/K2baDVtrTvRP3F0xuYBr/4m6DIjCpw366/aj4c28DcKqDJdVwekQqdz51k9Wip9qSxi2gyo CNu9408iRbTZIFF29R41/6lNoR/18SP4vSLdgSji6+ekGASA0k+1hopC4ERJXtLVXeTcnIhzG w2xB8xH+K5jUZyDUFwh7nv2806Gpp6nXjki8I79oY4lfbv3Q6n8+SgdoS7FTNy7j4KZPRtUCI waGiTHzBl1krsqCEU26cAcGjN5zr2MUNl1BMSMKF/u9D9RH9g882UGFc3SuOAl07UWxt+OIq9 jREYS5rMDbLuiQTc080eGTmtXfmKu/p3YdMR2vf8OGZF06b6xwTvhHNzr6XZbUhKpWM6IjKPZ ZZU7jXIoayaSSXYh3GghLYsCDAaWsX77YqD+xp9NuFk7NhTUSsoaEhddH/HRehF6oH1zItVbI ZpElrfnKeN0BkGPu36l781XnVfxwo865KxyeHZbqgW5WAFJBgDsjbohMDH7tpsHd7Zgc18dhE hZhA0P09pWhD4pjI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 25 January 2016 17:53:48 Arnd Bergmann wrote: > gcc correctly warns that the printk output contains a variable that > is not initialized in some cases: > > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll': > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:254:76: warning: 'todo' may be used uninitialized in this function [-Wmaybe-uninitialized] > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:144:15: note: 'todo' was declared here > > This adds an explicit initialization to zero in the exact case where it > was missing, to avoid leaking stack data to the console and to shut up > that warning. > > Signed-off-by: Arnd Bergmann > Sorry for the broken ordering and missing cover letter. I just submitted three crypto patches: [PATCH 1/4] crypto: sunxi - don't print uninitialized data [PATCH] crypto: hash - select CRYPTO_HASH where needed [PATCH 1/2] crypto: jitterentropy - always select CRYPTO_RNG These address independent build issues, and there is no ordering between them. None of them are important, so please queue them up for 4.6. Arnd