From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4A638F66; Thu, 5 Sep 2024 09:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725527496; cv=none; b=P9kbqhejv7Hi8lLRGlg4P9FHkpPIVgtI/3lWtg7z7suqE4fqlH+IfjXGuod2ZoMfiD5JhD9L88UoAQY4V3ulLvO101glJjEdjIrRAEgCPVZRbwmL+Eh9YNGePql61v/ivfikNmcroeMMo4R4Nk3SqHzX8j1cu/OwoBVdRoicnmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725527496; c=relaxed/simple; bh=jSnoM3pLb8NBQo6fnBm3w9pHSRBVjsIEE4tfavIuPlc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=r9ILMLB9WPtJDTLpu5Sn2cSJDxZ9W1CF/eIRKLMiE/HQiZCGU/FzAK5+UyTSTq6JP8bjpOMCCrZMJBdlQgBfyUIrnY5n95/5M/kPCN3TXl+if4g1uCWMPr77jKe4c9tGCenXpmKpJk+m0ThGguqHUQ3ETUA2kZDuOlMLGk4MjII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=plRGFvad; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="plRGFvad" Received: from [192.168.88.20] (91-156-87-48.elisa-laajakaista.fi [91.156.87.48]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C579FD52; Thu, 5 Sep 2024 11:10:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1725527413; bh=jSnoM3pLb8NBQo6fnBm3w9pHSRBVjsIEE4tfavIuPlc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=plRGFvadL1bj8DeXNoMGkYLY/FLKlkSnV9F41+rdatpP8yBf2RV6oovjYvNVTvpeG FyfdCZwNqVmsRRO3YEfuP3ggmB497UYyJqbnUJS8lXGDtBjLe6wpdpB2ZoEluG728e tMtSxAYpLIA+Y9G3HA26fooDsdNXEff3SPzuag58= Message-ID: <514490a2-181a-42ac-bc54-7a700e8d1bb9@ideasonboard.com> Date: Thu, 5 Sep 2024 12:11:19 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 00/12] media: ov5645: Add support for streams From: Tomi Valkeinen To: Prabhakar , Sakari Ailus , Laurent Pinchart , Kieran Bingham , Jacopo Mondi , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar References: <20240904210719.52466-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <3eeae62a-e22b-443a-aad4-f1a384c0a3f7@ideasonboard.com> Content-Language: en-US Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <3eeae62a-e22b-443a-aad4-f1a384c0a3f7@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/09/2024 09:48, Tomi Valkeinen wrote: > On 05/09/2024 00:07, Prabhakar wrote: >> From: Lad Prabhakar >> >> Hi All, >> >> This patch series aims to add the below features, >> - Support subdev active state >> - Support for streams >> - Support for virtual channel >> - Code cleanup >> >> Sending this is as an RFC, I've done limited testing and Im seeing issue >> when route is updated and wanted some feedback on the implementation. >> >> When route is updated for the sensor with below command, and when start >> streaming I get "Dangling sink streams: mask 0x1" error. Should the >> corresponding bridge also need to support routes to fix this? or is it >> something missing Ive missed in the current implementation. >> >> $ media-ctl -R "'ov5645 0-003c' [1/0->0/1[1]]" >> >> Output after route update: >> - entity 4: ov5645 0-003c (2 pads, 1 link, 1 route) >>              type V4L2 subdev subtype Sensor flags 0 >>              device node name /dev/v4l-subdev1 >>          routes: >>                  1/0 -> 0/1 [ACTIVE] >>          pad0: SOURCE >>                  [stream:1 fmt:UYVY8_1X16/1920x1080 field:none >> colorspace:srgb >>                   crop:(0,0)/1920x1080] >>                  -> "csi-10830400.csi2":0 [ENABLED,IMMUTABLE] >>          pad1: SINK,0x8 >>                  [stream:0 fmt:UYVY8_1X16/2592x1944 field:none >> colorspace:srgb >>                   crop:(0,0)/1920x1080] > > I think you actually want 1/0->0/0 routing. The error says that the sink > side device has routing which does not have a stream at stream ID 1, or > no routing support at all, which implies a single stream at stream ID 0. Looking at patch 12, there's something wrong with the approach here. Are you perhaps trying to define the CSI-2 VC with the streams? If you have a camera with a single image stream coming from an internal pad, you should have one hardcoded route, 1/0->0/0. The .get_frame_desc() should return the CSI-2 VC (most likely always 0) and DT (based on the format) for that stream. If you also have embedded data, then you'd have another internal pad (pad number 2), and the routing would be: 1/0->0/0 2/0->0/1 And here .get_frame_desc() would also handle the second stream, and most likely for that stream the VC would also be 0. The stream ID in the routing table is a software level concept, not related to the VC. Also, the internal pad should use the sensor's native format, not UYVY8_1X16. Tomi