From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE04C76196 for ; Sun, 2 Apr 2023 15:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230425AbjDBPoD (ORCPT ); Sun, 2 Apr 2023 11:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230283AbjDBPoC (ORCPT ); Sun, 2 Apr 2023 11:44:02 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDA67E042 for ; Sun, 2 Apr 2023 08:44:00 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id e9so12627944ljq.4 for ; Sun, 02 Apr 2023 08:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680450239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8jXhcT5ZVw1OvQ2qjM62gp4jmz1Chro5Ew3RaPugUX0=; b=vmjyzEB8Q2LRKXisvJ5vw0iEDdeP1zteah9BoGMk2wu89tKXwsIJ5SLD1Num8XYLlY nyvXxB+3DJM63pM1Mb+cEu/uLvI5pGoYB+Al1LGnC7N7FfqnMGl7kTOOCS27UgSGpd0y kJg60dEhsOKK2gAkWM/S+LcOm5sEQxGb1kLcp7fBYLZbBWcIfssbZKnTC4jrRVzMKYQ9 1Ywjb1KOKzDJyQEw0q0viRqNJWdqR6o4phLElQ9aN1hBakNScRj0ES1Xk5z8AxOJJt0M +LShuRN+U8SAXvGightjg12Jl+m9vSxV+wvjlUrnQYL4arer17yYGraL/lStU4YT5jUM ouwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680450239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8jXhcT5ZVw1OvQ2qjM62gp4jmz1Chro5Ew3RaPugUX0=; b=c50+0lkpf5S8NYZGPjkE2VR9IvxewW6LJEqvASv+fn51KnUY0+E0TpntKTkW4TPp+R JhFvS3bU70fhhy41YMjEIRgiGmgVTPrZkMiRLfzTk0qLI4SzJkH+A0pt+EnIjTrNPNsB bzoIgL5eyrOgEzwgu2bCh3qYkqh7ON4H0Ar9K7s3Cc0fgTej+c6/4xJDx3Oz1f9O6QVE VmAB8pDhxOEhR50PKfzlgX9BjTCowv3X7RVLbu7kqk1xHKtFnf6scGODfsUZtQbk1G2j fI68yR3towQFYCL77q3VGl1JY6NEBXBqUUmi2FBdMbbFYifJqExTjUDB0zE0bC9pQU3Q FKXg== X-Gm-Message-State: AAQBX9flqYEBJW82QPwMSGyqbr/cHUh5vYkpgJx5DL07r4Cl9DpjPzbm BJbvCns+q2E0ZOUROeGqDSFg17a1gVFoeujbsOfs9w== X-Google-Smtp-Source: AKy350Y5aEPWgsceuXkfIdTFwafBhWN+FGbs5H/6SNUrjipWa9ZUTqU9oADjjxRPo9rQbefvS5Srwg== X-Received: by 2002:a2e:9bc7:0:b0:293:4c17:9998 with SMTP id w7-20020a2e9bc7000000b002934c179998mr9990534ljj.11.1680450239095; Sun, 02 Apr 2023 08:43:59 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id q16-20020a2e8750000000b002935632b3f8sm1300173ljj.14.2023.04.02.08.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Apr 2023 08:43:58 -0700 (PDT) Message-ID: <51451dc1-14d5-595b-589e-1cbcb5468180@linaro.org> Date: Sun, 2 Apr 2023 18:43:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v6 01/15] drm/msm/adreno: adreno_gpu: Don't set OPP scaling clock w/ GMU Content-Language: en-GB To: Konrad Dybcio , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , Marijn Suijten References: <20230223-topic-gmuwrapper-v6-0-2034115bb60c@linaro.org> <20230223-topic-gmuwrapper-v6-1-2034115bb60c@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20230223-topic-gmuwrapper-v6-1-2034115bb60c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2023 14:54, Konrad Dybcio wrote: > Recently I contributed the switch to OPP API for all Adreno generations. > I did however also skip over the fact that GPUs with a GMU don't specify > a core clock of any kind in the GPU node. While that didn't break > anything, it did introduce unwanted spam in the dmesg: > > adreno 5000000.gpu: error -ENOENT: _opp_set_clknames: Couldn't find clock with name: core_clk > > Guard the entire logic so that it's not used with GMU-equipped GPUs. > > Fixes: 9f251f934012 ("drm/msm/adreno: Use OPP for every GPU generation") > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry