From: Yue Haibing <yuehaibing@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ipv6: mcast: Add ip6_mc_find_idev() helper
Date: Sat, 26 Jul 2025 09:31:17 +0800 [thread overview]
Message-ID: <514b2e53-83fd-43e3-aa1f-21b9ff14b31a@huawei.com> (raw)
In-Reply-To: <20250725144547.05a48cc1@kernel.org>
On 2025/7/26 5:45, Jakub Kicinski wrote:
> On Thu, 24 Jul 2025 19:56:31 +0800 Yue Haibing wrote:
>> net/ipv6/mcast.c | 76 +++++++++++++++++++++++-------------------------
>> 1 file changed, 36 insertions(+), 40 deletions(-)
>
> Dunno if this is worth the churn to save 4 lines.
> I was waiting to see if anyone will offer a review tag
> but it's getting a bit later in the review cycle,
> please try again after the merge window.
Ok, thank you for your review.
prev parent reply other threads:[~2025-07-26 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 11:56 Yue Haibing
2025-07-25 21:45 ` Jakub Kicinski
2025-07-26 1:31 ` Yue Haibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514b2e53-83fd-43e3-aa1f-21b9ff14b31a@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®