From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"paulburton@kernel.org" <paulburton@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v3 7/8] dt-bindings: mfd: Add img,boston-platform-regs
Date: Wed, 19 Jun 2024 12:20:54 +0100 [thread overview]
Message-ID: <51557e31-0a59-4278-a8c1-25cf66fa3c3f@app.fastmail.com> (raw)
In-Reply-To: <6d3fbd07-72a0-43fd-a1e5-c39e3a833bc1@kernel.org>
在2024年6月19日六月 上午10:28,Krzysztof Kozlowski写道:
> On 18/06/2024 17:11, Jiaxun Yang wrote:
>> This compatible has been used in arch/mips/boot/dts/img/boston.dts
>> for a while but never documented properly.
>>
>
>> diff --git a/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
>> new file mode 100644
>> index 000000000000..79cae87c6758
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/img,boston-platform-regs.yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/img,boston-platform-regs.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Imagination Technologies Boston Platform Registers
>> +
>> +maintainers:
>> + - Jiaxun Yang <jiaxun.yang@flygoat.com>
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - const: img,boston-platform-regs
>> + - const: syscon
>> + - const: simple-mfd
>
>
> Fix U-boot to populate devices instead of relying on simple-mfd.
Hi Krzysztof,
I believe U-Boot's implementation is correct. As per simple-mfd binding:
```
simple-mfd" - this signifies that the operating system should
consider all subnodes of the MFD device as separate devices akin to how
"simple-bus" indicates when to see subnodes as children for a simple
memory-mapped bus.
```
This reads to me as "if you want sub nodes to be populated as devices
you need this."
In our case there are "clock" and "reset" node sub nodes which should be
probed as regular device, so it's true for us.
Linux managed to work without "simple-mfd" only because clock subsystem
is bypassing regular OF population process. Semantically we need this.
Besides Linux as upstream of devicetree source had accepted U-Boot
only stuff here, such as "bootph-all" property.
Thanks
- Jiaxun
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clock-controller:
>> + type: object
>> +
>> + description: Boston Clock Controller Device Node
>> + The clock consumer should specify the desired clock by having the clock
>> + ID in its "clocks" phandle cell.
>> + See include/dt-bindings/clock/boston-clock.h for the full list of boston
>> + clock IDs.
>> +
>> + properties:
>> + "#clock-cells":
>> + const: 1
>> +
>> + compatible:
>> + const: img,boston-clock
>
> Please put compatible first in the list of properties (and follow the
> same order in "required"). It's the most important piece, so we want it
> to be the first to see. It also follows the convention of DTS, where
> compatible is expected to be first.
>
>> +
>> + required:
>> + - "#clock-cells"
>> + - compatible
>> +
>> + additionalProperties: false
>> +
>> + reboot:
>> + $ref: /schemas/power/reset/syscon-reboot.yaml#
>
>
> Best regards,
> Krzysztof
--
- Jiaxun
next prev parent reply other threads:[~2024-06-19 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 15:11 [PATCH v3 0/8] MIPS: Boston: Fix syscon devicetree binding and node Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 1/8] MIPS: dts: Boston: Add simple-mfd compatible for syscon Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 2/8] MIPS: dts: Boston: Move syscon-reboot node under syscon Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 3/8] MIPS: dts: Boston: Rename clock node as clock-controller Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 4/8] MIPS: dts: Boston: Remove unused #interrupt-cells Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 5/8] MIPS: dts: Boston: Add model property Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 6/8] MIPS: dts: Boston: Rename uart node Jiaxun Yang
2024-06-18 15:11 ` [PATCH v3 7/8] dt-bindings: mfd: Add img,boston-platform-regs Jiaxun Yang
2024-06-19 9:28 ` Krzysztof Kozlowski
2024-06-19 11:20 ` Jiaxun Yang [this message]
2024-06-20 6:40 ` Krzysztof Kozlowski
2024-06-20 16:13 ` Jiaxun Yang
2024-06-20 16:16 ` Krzysztof Kozlowski
2024-06-20 16:32 ` Jiaxun Yang
2024-06-21 15:51 ` Jiaxun Yang
2024-06-22 18:12 ` Krzysztof Kozlowski
2024-06-22 19:06 ` Jiaxun Yang
2024-06-27 20:44 ` Rob Herring
2024-06-18 15:11 ` [PATCH v3 8/8] dt-bindings: mips: img: Add devices binding Jiaxun Yang
2024-06-20 6:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51557e31-0a59-4278-a8c1-25cf66fa3c3f@app.fastmail.com \
--to=jiaxun.yang@flygoat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®