From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40427C433ED for ; Mon, 17 May 2021 14:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2769C61476 for ; Mon, 17 May 2021 14:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239425AbhEQO0v (ORCPT ); Mon, 17 May 2021 10:26:51 -0400 Received: from foss.arm.com ([217.140.110.172]:53136 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235539AbhEQOW6 (ORCPT ); Mon, 17 May 2021 10:22:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4187C12FC; Mon, 17 May 2021 07:21:41 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DEB4B3F73B; Mon, 17 May 2021 07:21:37 -0700 (PDT) Subject: Re: [PATCH v3 4/6] sched/fair: Carve out logic to mark a group for asymmetric packing To: Ricardo Neri , "Peter Zijlstra (Intel)" , Ingo Molnar , Juri Lelli , Vincent Guittot Cc: Steven Rostedt , Ben Segall , Mel Gorman , Len Brown , Srinivas Pandruvada , Tim Chen , Aubrey Li , "Ravi V. Shankar" , Ricardo Neri , Quentin Perret , "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, Aubrey Li , Daniel Bristot de Oliveira References: <20210513154909.6385-1-ricardo.neri-calderon@linux.intel.com> <20210513154909.6385-5-ricardo.neri-calderon@linux.intel.com> From: Dietmar Eggemann Message-ID: <51599adc-d7e6-9d29-9c17-a49e0c2e315e@arm.com> Date: Mon, 17 May 2021 16:21:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210513154909.6385-5-ricardo.neri-calderon@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/05/2021 17:49, Ricardo Neri wrote: [...] > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index c8c04e9d0d3b..c8b66a5d593e 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8447,6 +8447,20 @@ group_type group_classify(unsigned int imbalance_pct, > return group_has_spare; > } > > +static inline bool > +sched_asym(struct lb_env *env, struct sd_lb_stats *sds, struct sg_lb_stats *sgs, > + struct sched_group *group) > +{ > + /* > + * Because sd->groups starts with the local group, anything that isn't > + * the local group will have access to the local state. > + */ > + if (group == sds->local) > + return false; sched_asym() is called under if(!local_group ...) from update_sg_lb_stats(). So why checking this here again? [...]