From: Jeff Garzik <jgarzik@pobox.com>
To: Gwendal Grignou <gwendal@google.com>
Cc: zarniwhoop@ntlworld.com, linux-kernel@vger.kernel.org,
jgarzik@redhat.com
Subject: Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check
Date: Wed, 03 Apr 2013 19:49:48 -0400 [thread overview]
Message-ID: <515CC01C.3070502@pobox.com> (raw)
In-Reply-To: <1364536609-17398-1-git-send-email-gwendal@google.com>
On 03/29/2013 01:56 AM, Gwendal Grignou wrote:
> commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key
> used for returning task registers, but HDIO_DRIVE_CMD ioctl was
> not changed accordingly.
>
> Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0
> instead of EIO.
>
> Signed-off-by: Gwendal Grignou <gwendal@google.com>
> ---
> drivers/ata/libata-scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied the version from Krzysztof Mazur, which covered both cases
next prev parent reply other threads:[~2013-04-03 23:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 1:01 smartd broken in 3.9.0-rc4 Ken Moffat
2013-03-28 20:59 ` smartd broken in 3.9.0-rc4 : bisected Ken Moffat
2013-03-29 0:56 ` Gwendal Grignou
2013-03-29 5:56 ` [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check Gwendal Grignou
2013-03-29 18:31 ` Ken Moffat
2013-03-29 20:34 ` Ken Moffat
2013-03-29 23:30 ` Ken Moffat
2013-04-03 23:49 ` Jeff Garzik [this message]
2013-04-04 18:25 ` Gwendal Grignou
2013-04-08 22:07 ` Ken Moffat
-- strict thread matches above, loose matches on Subject: below --
2013-03-25 17:26 ata: HDIO_DRIVE_* ioctl() Linux 3.9 regression Ronald
2013-03-29 15:26 ` [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check Gwendal Grignou
2013-03-29 16:10 ` Krzysztof Mazur
2013-03-29 17:06 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515CC01C.3070502@pobox.com \
--to=jgarzik@pobox.com \
--cc=gwendal@google.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zarniwhoop@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome