From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rui.zhang@intel.com, amitk@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/4] thermal/core: Rename passive_delay and polling_delay with units
Date: Thu, 10 Dec 2020 15:49:24 +0000 [thread overview]
Message-ID: <515c6301-0f52-2975-2ef0-1efda6fffdba@arm.com> (raw)
In-Reply-To: <20201207190902.30464-1-daniel.lezcano@linaro.org>
On 12/7/20 7:08 PM, Daniel Lezcano wrote:
> The input unit used by the thermal framework is the msec but it uses
> the jiffies to set the timers.
>
> As it is stored in the thermal zone device structure, everytime the
> timer is setup at each polling interval, the msecs to jiffies
> conversion happens. The jiffies is the unit the thermal framework is
> using, so keeping it under the jiffies instead of msecs will save some
> pointless conversion.
Make sense
>
> Set the scene to directly store the delays under their jiffies
> form by adding to the variable name the 'ms' suffix.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
prev parent reply other threads:[~2020-12-10 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 19:08 Daniel Lezcano
2020-12-07 19:09 ` [PATCH v2 2/4] thermal/core: Precompute the delays from msecs to jiffies Daniel Lezcano
2020-12-10 15:58 ` Lukasz Luba
2020-12-07 19:09 ` [PATCH v2 3/4] thermal/core: Use precomputed jiffies for the polling Daniel Lezcano
2020-12-10 16:02 ` Lukasz Luba
2020-12-07 19:09 ` [PATCH v2 4/4] thermal/core: Remove ms based delay fields Daniel Lezcano
2020-12-10 16:25 ` Lukasz Luba
2020-12-10 15:33 ` [PATCH v2 1/4] thermal/core: Rename passive_delay and polling_delay with units Daniel Lezcano
2020-12-10 15:49 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515c6301-0f52-2975-2ef0-1efda6fffdba@arm.com \
--to=lukasz.luba@arm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®