From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159AbbJGNbS (ORCPT ); Wed, 7 Oct 2015 09:31:18 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:61797 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbbJGNbR (ORCPT ); Wed, 7 Oct 2015 09:31:17 -0400 From: Arnd Bergmann To: Florian Fainelli Cc: Thierry Reding , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, ariel@vanguardiasur.com.ar Subject: Re: [PATCH] pwm: fix Broadcom BCM7038 PWM driver Date: Wed, 07 Oct 2015 15:31:07 +0200 Message-ID: <51655489.62UKkKA6xS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56146C92.7090606@gmail.com> References: <1442274426-3507-1-git-send-email-f.fainelli@gmail.com> <6796852.Ynn1zMqb4r@wuerfel> <56146C92.7090606@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tZMoXpM/hJ5sS9G/7jVzGgZEuVCUHrYqefzUJthruHsHrVNGenG 8lMHmJ1cgZiBabR7wTq++84J9YgItVQCOUONPuGjXn2EPhI+AJUsvu1WMqJu21MluKzru3T 10dc7jsp1FIr4hY8zMPFypoQEA6TPCTGv1eEvNOBPa8zAa10BuL2tVt+U25Zq1R0iKO0BEl 9Zi8E/D+tfUkePf8lTMAw== X-UI-Out-Filterresults: notjunk:1;V01:K0:pg3W7zaQ8tA=:3fQSIdWWTtz3TGEk4lUbqi qG7WWQ8QuVrrvkpV4vwjeYAGBBs88UUPV1iJf1LUW5Bir09E7zMAkSAllI26QmNrckdY7YQRX 7JU86FCpqplM55sYIIekKKGx/LFGg+I2W1P4gdJ7isNY4vuA1qAUnTq565hzSMZlSjfIaaN5p Q6uCtpFPKWT33np5ASCTXTxg5DYNrEOpAqocRbDKc+I3R/2yrZaTrj1eUahFBS69QkOB8ZQKy T3VF8OqyXSnp45On0WCul4ax8pf3MVh5tKUdAboy9i9eKT2ZRIvKjodDnLimkvGC+Hk0xd+ac iUw/ubi49MPWhl6ph7Gl+NioPFj55wLtztuWqjzHgIsF43Fkh5/W6XBDtp4iwtNZS9IeCvakz rR/PtonOMum21PGNK7onlidaBAgLurCaNBVRimzJfhegtflNJcRXSefxVzHo953w8KuBizwpm fe+F2R66y+Yexvkt5FnYyVFTdhIAy0p+xjINYNKDyTAbwCpes+zQtWQXHEY1+BKzfFauUhKeQ pjS+KbLBX9NH1Nl08juWq9TM+dNxhrWNllA4RyPj+RE5qrweEKyNWe2v9UsFghtnMaORqeeL0 zTgads0E+M2P0r0jRdiNRFoXxYKtEJPBZEzmCdZcK7gLgWXu9wDh72D3Vuvma2nZa0+6/niZA jr0pmKuqzuVml/nFbAeZVCwDzd3+93KNWC2prnAFLQgvgLlFxdokv2VKMtFSqSH5bS19dhPlL K1F0YeLdigpS0ap0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 06 October 2015 17:51:30 Florian Fainelli wrote: > On 06/10/15 12:59, Arnd Bergmann wrote: > > The newly added pwm-brcmstb driver fails to build if CONFIG_PM_SLEEP > > is enabled: > > > > drivers/pwm/pwm-brcmstb.c: In function 'brcmstb_pwm_suspend': > > drivers/pwm/pwm-brcmstb.c:309:42: error: 'dev' undeclared (first use in this function) > > struct brcmstb_pwm *p = dev_get_drvdata(dev); > > > > This changes the name of the function argument to match its user. > > Thanks, maybe, to avoid similar issues in the future, we should start > removing the ifdef CONFIG_PM_SLEEP and instead annotate such functions > with __maybe_unused. I wonder if we could magically make that happen > with a coccinelle script that looks for SIMPLE_DEV_PM_OPS to know which > functions to annotate... humm. I think the best solution would be to replace SIMPLE_DEV_PM_OPS with a macro that creates an unused reference to the functions. That way, we could remove all the #ifdef CONFIG_PM_SLEEP from the kernel, but we'd still have to use coccinelle to replace all the current instances with the new macro. Arnd