From: Andrew Lunn <andrew@lunn.ch>
To: netdev-bot+sashiko@kernel.org
Cc: jacky_chou@aspeedtech.com, andrew+netdev@lunn.ch,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
ratbert@faraday-tech.com, edumazet@kernel.org,
hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 2/7] dt-bindings: net: ftgmac100: Add AST2700 compatible
Date: Mon, 16 Nov 2026 15:10:21 +0100 [thread overview]
Message-ID: <51667f1f-4f2b-44ea-b725-87cf63c2c9dc@lunn.ch> (raw)
In-Reply-To: <179483725554.3136.8359940788845125105@kernel.org>
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: aspeed,ast2700-mac
> > + then:
> > + required:
> > + - phy-mode
>
> [Severity: Medium]
> Is phy-mode really mandatory for every AST2700 MAC node? The binding
> also documents the use-ncsi boolean. That mode runs the NC-SI stack
> over RMII instead of talking to an MDIO PHY. The first example in this
> file sets use-ncsi and has no phy-mode property, and that is a valid
> setup on the earlier Aspeed parts.
This seems like a valid point. Maybe make it conditional like the
code, either phy-mode, or use-ncsi. Both or neither is invalid.
Andrew
next prev parent reply other threads:[~2026-11-16 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:39 [PATCH net-next v6 0/7] net: ftgmac100: Add AST2700 support Jacky Chou
2026-11-12 8:39 ` [PATCH net-next v6 1/7] dt-bindings: net: ftgmac100: Make Aspeed compatibles standalone Jacky Chou
2026-11-12 18:43 ` Conor Dooley
2026-11-16 13:54 ` netdev-bot+sashiko
2026-11-12 8:39 ` [PATCH net-next v6 2/7] dt-bindings: net: ftgmac100: Add AST2700 compatible Jacky Chou
2026-11-12 18:44 ` Conor Dooley
2026-11-16 13:54 ` netdev-bot+sashiko
2026-11-16 14:10 ` Andrew Lunn [this message]
2026-11-12 8:39 ` [PATCH net-next v6 3/7] net: ftgmac100: Add AST2700 compatible support Jacky Chou
2026-11-16 13:54 ` netdev-bot+sashiko
2026-11-12 8:39 ` [PATCH net-next v6 4/7] net: ftgmac100: Enable AST2700 RMII support Jacky Chou
2026-11-16 13:54 ` netdev-bot+sashiko
2026-11-12 8:39 ` [PATCH net-next v6 5/7] net: ftgmac100: Require phy-mode for AST2700 Jacky Chou
2026-11-16 13:54 ` netdev-bot+sashiko
2026-11-12 8:39 ` [PATCH net-next v6 6/7] net: ftgmac100: Add AST2700 upper DMA address support Jacky Chou
2026-11-16 13:54 ` netdev-bot+sashiko
2026-11-12 8:39 ` [PATCH net-next v6 7/7] net: ftgmac100: Allow building on ARM64 Jacky Chou
2026-11-16 13:54 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51667f1f-4f2b-44ea-b725-87cf63c2c9dc@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jacky_chou@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ratbert@faraday-tech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®