From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F243BF676 for ; Mon, 13 Jul 2026 08:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932588; cv=none; b=BGv4KQg3UYELiYSv3lBjaly6q9nAPHGgNlmtsBYNctq7w+mOFdVjeuho9hRL19+r+SU+JrqLBytU7Z1QPFKg14m3tW0syIb/KF8cxI8kTh3e28FlOTHEqRycQv9IyUd8pN2wIjLCZ5yh+gPccl5d+5P+DqFpL7D/UBtWV0Zrrz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783932588; c=relaxed/simple; bh=hY8dyarXIKwBd/nlLepRXDiemsDlpKAY73JCbyT74hQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HfZcAduTas3kAh/FZwicSZnuCJrzztOOuM2hmNPvUv58yl1DmQK3yEITsIkjYsOeks+JKHTU9b6DTRwGk/6wUBT0axNPVQUgEhkQrv/Q7NtAqj8xGECGJ8357JS5qBqp/KEdf+IUgic3uqY7ycpiSs+1vetgmmPCccCA/+nGNz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PBH5jl25; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PBH5jl25" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B19CC1F00A3A; Mon, 13 Jul 2026 08:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783932586; bh=PLDbO2ux1cY+txVE9sdrFeOPn/1RnZEg4d0TU1FyKEA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PBH5jl25LXJEls7/oarnaC+4/Nf7AQbLZkOleoVwnrhtg0NlFDG2ZMGErzRHwk+VF uAjlKgiw74t2KkpMB8KphdeDfoFV00Jv3B5+1rqhn2Y7xUjd7K7F9AVLdyzITGzaN6 68w02zxCvfig0Dhlygno3lLVvAAbYNEAzX8Rt71oemrVbYh0/UIdE3QQWgDY//FUFE t5QsXKUfz2zTXg+iyWDkevNPQRWc0NI5seDggqqk011D+zDKqUL0LE0t9jFOfgXMRn Qn7qjwrwJwKU1b3vH350lJfGqKo0BFkhMsGk22LooGSKtas2sj0MHK8/ajIsSmxQoN WYQ4asBUuz3Vg== Message-ID: <516b7984-f4c0-4cf0-bd40-104579950b0a@kernel.org> Date: Mon, 13 Jul 2026 17:49:29 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/slub: add comment explaining intentional kobject handling in sysfs_slab_add To: Hongling Zeng , Hongling Zeng , vbabka@kernel.org, akpm@linux-foundation.org, hao.li@linux.dev, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, vdavydov.dev@gmail.com, davej@fedoraproject.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260713070024.153552-1-zenghongling@kylinos.cn> <6A549790.3000203@126.com> Content-Language: en-US From: Harry Yoo In-Reply-To: <6A549790.3000203@126.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4fA11zKehzKXGsuWEFtyDd9J" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4fA11zKehzKXGsuWEFtyDd9J Content-Type: multipart/mixed; boundary="------------ryp4bYEw4U5j0686JzItSYb1"; protected-headers="v1" From: Harry Yoo To: Hongling Zeng , Hongling Zeng , vbabka@kernel.org, akpm@linux-foundation.org, hao.li@linux.dev, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, vdavydov.dev@gmail.com, davej@fedoraproject.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-ID: <516b7984-f4c0-4cf0-bd40-104579950b0a@kernel.org> Subject: Re: [PATCH v1] mm/slub: add comment explaining intentional kobject handling in sysfs_slab_add References: <20260713070024.153552-1-zenghongling@kylinos.cn> <6A549790.3000203@126.com> In-Reply-To: <6A549790.3000203@126.com> --------------ryp4bYEw4U5j0686JzItSYb1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 7/13/26 4:45 PM, Hongling Zeng wrote: > =E5=9C=A8 2026=E5=B9=B407=E6=9C=8813=E6=97=A5 15:26, Harry Yoo =E5=86=99= =E9=81=93: >> On 7/13/26 4:00 PM, Hongling Zeng wrote: >>> Add a comment to clarify why we don't call kobject_put() when >>> kobject_init_and_add() fails in sysfs_slab_add(). >>> >>> Per commit 2420baa8e046 ("mm/slab: Allow cache creation to proceed >>> even if sysfs registration fails"), sysfs failures are treated as >>> non-fatal and the cache continues to be used. Calling kobject_put() >>> would trigger slab_kmem_cache_release() which frees the entire >>> cache structure, so we intentionally skip it. >>> >>> Suggested-by: Harry Yoo >>> Signed-off-by: Hongling Zeng >>> --- FWIW, the patch looks fine to me, so: Acked-by: Harry Yoo (Oracle) >>> Change in v1: >>> -Correct the email >> >> Hmm, the email "Hyeonggon Kim " came out of >> nowhere. Could you please explain why this happened? > My apologies for the confusion. >=20 > I incorrectly retrieved your email from a signature search =EF=BC=9A=EF= =BC=89 You mean retrieved from your local address book? --=20 Cheers, Harry / Hyeonggon --------------ryp4bYEw4U5j0686JzItSYb1-- --------------4fA11zKehzKXGsuWEFtyDd9J Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQQ1ub6gR5ogjaKRmOGXBN6rc5S1gUCalSmmQAKCRCGXBN6rc5S 1u0GAP41vO5nCpfps7FFbzIRUsDo5ifNrkITLq4kQ1zGVBogqwD5AfGV009Enkzu 3F7bADT4jGuJitJodPUWDW4f46euCQ0= =pPc0 -----END PGP SIGNATURE----- --------------4fA11zKehzKXGsuWEFtyDd9J--