From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167AbdFCLNe (ORCPT ); Sat, 3 Jun 2017 07:13:34 -0400 Received: from smtp-sh2.infomaniak.ch ([128.65.195.6]:45595 "EHLO smtp-sh2.infomaniak.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbdFCLNc (ORCPT ); Sat, 3 Jun 2017 07:13:32 -0400 Subject: Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies To: shuah@kernel.org, linux-kernel@vger.kernel.org References: <20170526184402.30267-1-mic@digikod.net> <20170526184402.30267-4-mic@digikod.net> Cc: Andy Lutomirski , Jonathan Corbet , Kees Cook , Will Drewry , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <516eafac-7f32-5ddf-44cc-83edbd14c90c@digikod.net> Date: Sat, 3 Jun 2017 13:13:06 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uLadRDSGoLdnO7jlLejcl0M7Hxlvc7Pbm" X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8 X-Antivirus-Code: 0x100000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uLadRDSGoLdnO7jlLejcl0M7Hxlvc7Pbm Content-Type: multipart/mixed; boundary="CO5ciiFn2txR1JGseFD8N4akXfuclihsv"; protected-headers="v1" From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= To: shuah@kernel.org, linux-kernel@vger.kernel.org Cc: Andy Lutomirski , Jonathan Corbet , Kees Cook , Will Drewry , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan Message-ID: <516eafac-7f32-5ddf-44cc-83edbd14c90c@digikod.net> Subject: Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies References: <20170526184402.30267-1-mic@digikod.net> <20170526184402.30267-4-mic@digikod.net> In-Reply-To: --CO5ciiFn2txR1JGseFD8N4akXfuclihsv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Shuah, On 02/06/2017 21:31, Shuah Khan wrote: > Hi Micka=C3=ABl, >=20 > On 05/26/2017 12:43 PM, Micka=C3=ABl Sala=C3=BCn wrote: >> Rebuild the seccomp tests when kselftest_harness.h is updated. >> >> Signed-off-by: Micka=C3=ABl Sala=C3=BCn >> Acked-by: Kees Cook >> Cc: Andy Lutomirski >> Cc: Shuah Khan >> Cc: Will Drewry >> --- >> tools/testing/selftests/seccomp/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/= selftests/seccomp/Makefile >> index 5fa6fd2246b1..aeb0c805f3ca 100644 >> --- a/tools/testing/selftests/seccomp/Makefile >> +++ b/tools/testing/selftests/seccomp/Makefile >> @@ -4,3 +4,5 @@ LDFLAGS +=3D -lpthread >> =20 >> include ../lib.mk >> =20 >> +$(TEST_GEN_PROGS): seccomp_bpf.c ../kselftest_harness.h >> + $(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ >> >=20 > This change breaks seccomp build: >=20 > make -C tools/testing/selftests/seccomp/ > make: Entering directory '/mnt/data/lkml/linux_4.12/tools/testing/selft= ests/seccomp' > make: *** No rule to make target '../kselftest_harness.h', needed by '/= mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'. S= top. > make: Leaving directory '/mnt/data/lkml/linux_4.12/tools/testing/selfte= sts/seccomp' > shuah@mazurka:/mnt/data/lkml/linux_4.12$ cd tools/testing/selftests/sec= comp/ > shuah@mazurka:/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp= $ make > make: *** No rule to make target '../kselftest_harness.h', needed by '/= mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'. S= top. >=20 >=20 > Did you happen to try building with this change? Yes I did, and it builds fine for me (with the same command and patches). There is only one warning from GCC with =2E./kselftest_harness.h:368 because of the trick from OPTIONAL_HANDLER()= , which is intentional (and not modified by my patches). I don't get why your "make" said that there is "No rule to make target" =2E./kselftest_harness.h . This file exists (patch 1/7) so there is no need to create it=E2=80=A6 gen_kselftest_tar.sh works fine too. Thanks, Micka=C3=ABl --CO5ciiFn2txR1JGseFD8N4akXfuclihsv-- --uLadRDSGoLdnO7jlLejcl0M7Hxlvc7Pbm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUysCyY8er9Axt7hqIt7+33O9apUFAlkymcIACgkQIt7+33O9 apUi8wf+IaOj9QEYUwogTWzeznJFHm3yNsEu11O6BbBxtfGDsAQZ6ACWvHwY55KP G2PDIQ4R/HwGKmaHq2t1smgQSyz9NiZGpm885X+NQ8jPfQ7Hy5EVC4fx4psu19tW QR8oPNALAI6HSiJRAHnFz9G501ClYcCG4tzpEohcE19zwzqaYN7d4fLtX2g6Of6K wNlkSLOyi2ok/8n0Z2NbmqtewTiieisUQfjrWLHvn/FSUWItiI/CgfFIycP3hXuN ywKawXDOGDPs6NKDnypB5e9cUQAPZzQjdSsGIUZxaPTr37WkTUlUTqYA0fWdMY1m F36FUcFDJ34+rcExmQjW8fNcZXLMyA== =6I8t -----END PGP SIGNATURE----- --uLadRDSGoLdnO7jlLejcl0M7Hxlvc7Pbm--