From: Jon Hunter <jon-hunter@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Vinod Koul <vinod.koul@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] dma:of: Use a mutex to protect the of_dma_list
Date: Sun, 21 Apr 2013 20:18:39 -0500 [thread overview]
Message-ID: <51748FEF.7050703@ti.com> (raw)
In-Reply-To: <201304201238.08908.arnd@arndb.de>
On 04/20/2013 05:38 AM, Arnd Bergmann wrote:
> On Saturday 20 April 2013, Lars-Peter Clausen wrote:
>> On 04/20/2013 12:45 AM, Jon Hunter wrote:
>>> I think that there is a problem here. For controllers using the
>>> of_dma_simple_xlate(), this will call dma_request_channel() which also
>>> uses a mutex.
>>
>> That would only be a problem if it'd use the same mutex. Holding two mutexes at
>> the same time is not a problem per se.
>>
>
> I guess Jon originlly tried it with a spinlock as the outer lock, which indeed
> does not work, but the new version does not have this problem.
Yes the spinlock was a problem and hence for the put/get functions. Ok
so that's fine then.
Cheers
Jon
next prev parent reply other threads:[~2013-04-22 1:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 9:42 [PATCH 1/2] dma: of: Fix of_node reference leak Lars-Peter Clausen
2013-04-19 9:42 ` [PATCH 2/2] dma:of: Use a mutex to protect the of_dma_list Lars-Peter Clausen
2013-04-19 10:13 ` Arnd Bergmann
2013-04-19 11:04 ` Lars-Peter Clausen
2013-04-19 12:25 ` Arnd Bergmann
2013-04-19 22:45 ` Jon Hunter
2013-04-19 23:13 ` Arnd Bergmann
2013-04-22 1:22 ` Jon Hunter
2013-04-20 7:28 ` Lars-Peter Clausen
2013-04-20 10:38 ` Arnd Bergmann
2013-04-22 1:18 ` Jon Hunter [this message]
2013-04-19 10:10 ` [PATCH 1/2] dma: of: Fix of_node reference leak Arnd Bergmann
2013-04-19 22:29 ` Jon Hunter
2013-05-02 16:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51748FEF.7050703@ti.com \
--to=jon-hunter@ti.com \
--cc=arnd@arndb.de \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome