mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jijie Shao <shaojijie@huawei.com>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<shenjian15@huawei.com>, <wangjie125@huawei.com>,
	<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED
Date: Sat, 16 Mar 2024 19:17:55 +0800	[thread overview]
Message-ID: <5178c9fa-711a-4a91-ba1c-4b10da7592b3@huawei.com> (raw)
In-Reply-To: <ZfSOZG5vHbIY3IFU@localhost.localdomain>


on 2024/3/16 2:07, Michal Kubiak wrote:
> On Fri, Mar 15, 2024 at 06:07:48PM +0800, Jijie Shao wrote:
>> From: Jian Shen <shenjian15@huawei.com>
>>
>> Currently, loopback test maybe skipped when resetting, but the test
> typo: maybe skipped -> may be skipped
>
>> result will still show as 'PASS', because the driver doesn't set
>> ETH_TEST_FL_FAILED flag. Fixes it by set the flag and initialize the
>> value to be UNEXECUTED.
> Fix it by setting the flag and initializating the value to UNEXECUTED.
>
>
>> Fixes: 4c8dab1c709c ("net: hns3: reconstruct function hns3_self_test")
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>

Thanks，

I have sent V2 to fix them.

Jijie


      reply	other threads:[~2024-03-16 11:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 10:07 [PATCH net 0/3] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-03-15 10:07 ` [PATCH net 1/3] net: hns3: fix index limit to support all queue stats Jijie Shao
2024-03-15 17:33   ` Michal Kubiak
2024-03-15 10:07 ` [PATCH net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Jijie Shao
2024-03-15 17:48   ` Michal Kubiak
2024-03-15 10:07 ` [PATCH net 3/3] net: hns3: mark unexcuted loopback test result as UNEXECUTED Jijie Shao
2024-03-15 18:07   ` Michal Kubiak
2024-03-16 11:17     ` Jijie Shao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5178c9fa-711a-4a91-ba1c-4b10da7592b3@huawei.com \
    --to=shaojijie@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=michal.kubiak@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=wangjie125@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®