From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 407C6263C8C for ; Sat, 1 Aug 2026 12:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785587178; cv=none; b=phXLE3xjH9R/My6YzxTMq8v0fJUqFcqv0tR1LEIec7cNER/G116zFS8hGwZ2HldHCbBaI1RNzbZk28dht75kkzTqhS3CEO2tvnN+o9i72+LU0aFOokvm3R3QMPM9otEPA4lOVpEOxuAA4mB7GfVVFuU+qF/EsxIbfnJY8x0k1VI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785587178; c=relaxed/simple; bh=R67Sw9yUC/EcJA8IYCfxtBDdbTDGB8zRz0gHk9I6WuY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mREzeDS7XSxhLXnq17gB2MC4bOZkvtwGU/iGWwd3nOuNqktRKJjZO64+K1mRwzjOyPmpTgzl9vxDkwILrZOFuU4xYs47ZTHRueJvSdFV4ptDPOEaHIJSPwWwbpCCFwxiNZk22wYuXZ++hR4aVWpjQmiH1jimKv8tTWFG/quesSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b=ge8yd6Os; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b="ge8yd6Os" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6gqsKOBXgwlz/fp4G98DolG7aXkw+YyYtdxuPRvONHc=; b=ge8yd6OsYG8R/btIAop5/hx959 yi4BTBL4CLZPTIkxK9WI43u5zsVW4D/gB78kaod2Uhbdx//c5Q2/Hcuqh/zCJhy5tsY2AGHDvEBSe 1rRHfgINrxP8ChGPzrdCODCJ760mu5At0ZlUzx1BK2sBXsQlQq2rrJh1VneOHWAgskvtZm8hpquVU S5SIyEEvOgVQdpa1P1pg91jmvxVtecBUMt79JtQumgkaYfTwnICRbFdKHHOp1kgttLDqvz5uNQMpd 8UXVPvTtME6Yt4TpMvsApX3cQsxtz4uKxeCn8jdu+dkX5wUNrrhvpqFTb+/uWTc9jGaCYY9C917wI 1LjkBgHA==; Received: from [96.67.55.146] by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1wq8ml-000000001xk-1L48; Sat, 01 Aug 2026 08:25:51 -0400 Message-ID: <517bf6a8072a6e66f28f8ec08bec4b604f29491d.camel@surriel.com> Subject: Re: [PATCH RFC] mm/gup: batch contiguous pages in follow_page_mask() and return them via a pages array From: Rik van Riel To: "Lorenzo Stoakes (ARM)" Cc: David Hildenbrand , Andrew Morton , Jason Gunthorpe , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Aristeu Rozanski Date: Sat, 01 Aug 2026 08:25:50 -0400 In-Reply-To: References: <20260730035350.1fc95dd8@fangorn> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-08-01 at 10:54 +0100, Lorenzo Stoakes (ARM) wrote: >=20 > Thanks for doing a human pass but it LLM's habits really carried > through > here. In general: >=20 > - No walls of text please - fewer words are better, clarity is king. >=20 > - Don't write the code in English as a comment/commit msg - redudant > and > =C2=A0 distracting. >=20 > - Sensible patch separation obviously please. >=20 > - Write as elegant/reasonable code as possible. If the code you touch > was > =C2=A0 some horrible mega-function, take the time to refactor it. Pay dow= n > =C2=A0 technical debt. >=20 > These are all things LLMs are extremely bad at (even fable). So they > need > to be done by a human. LLMs can apply those rules, when expressed in a way that they get interpreted unambiguously by the LLM. I'm slowly building up a collection of such rules in the kernel-style repository. AI can write in any style you ask it to. /* * Long in the Halls of Rq the weary wait, =20 * till __schedule, herald of the turning years, =20 * calls forth the next to walk the road of fate =20 * as prev fades west. =20 */ =20 AI can also flag such issues, once it knows to look for them.=20 >=20 > >=20 > > In order for them to produce code that is at least a > > good starting point for editing, they need to follow > > rules. > >=20 > > Once you apply the rules, Opus and Sonnet do not > > produce results that are all that different from > > each other. > >=20 > > I just added a few new rules, so the tooling won't > > even let me create too-large patches any more. >=20 > I mean, sure, but what's needed here is human Rik :) The 80/20 rule comes into play here. If AI produces junk, the person starting with LLM-produced code can spend days cleaning it up, without getting things in a reasonable state. If the AI produces a better starting point, the=C2=A0 remaining issues will stand out like a sore thumb,=C2=A0 and it's much easier to find and fix them. I agree there will always be a need for human judgment, but that doesn't mean we should not improve our tooling. --=20 All Rights Reversed.