mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Wang Jianchao (Kuaishou)" <jianchao.wan9@gmail.com>,
	Jens Axboe <axboe@kernel.dk>
Cc: hch@infradead.org, Josef Bacik <jbacik@fb.com>,
	Tejun Heo <tj@kernel.org>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V2 1/6] blk: make blk-rq-qos support pluggable and modular policy
Date: Tue, 15 Feb 2022 13:23:46 -0800	[thread overview]
Message-ID: <517dddb8-efd6-6b1a-fa1b-eba6f2c93119@acm.org> (raw)
In-Reply-To: <20220215123705.58968-2-jianchao.wan9@gmail.com>

On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote:
> @@ -337,6 +338,7 @@ void blk_cleanup_queue(struct request_queue *q)
>   	 * it is safe to free requests now.
>   	 */
>   	mutex_lock(&q->sysfs_lock);
> +	rq_qos_exit(q);
>   	if (q->elevator)
>   		blk_mq_sched_free_rqs(q);
>   	mutex_unlock(&q->sysfs_lock);

I think this change should be a separate patch with tag "Fixes: 
8e141f9eb803 ("block: drain file system I/O on del_gendisk")". See also 
https://lore.kernel.org/linux-block/b64942a1-0f7e-9e9c-0fd4-c35647035eaf@acm.org/

Thanks,

Bart.

  reply	other threads:[~2022-02-15 21:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 12:36 [RFC V2 0/6] blk: make blk-rq-qos policies pluggable and modular Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 1/6] blk: make blk-rq-qos support pluggable and modular policy Wang Jianchao (Kuaishou)
2022-02-15 21:23   ` Bart Van Assche [this message]
2022-02-16  2:11     ` Wang Jianchao
2022-02-15 12:37 ` [RFC V2 2/6] blk-wbt: make wbt pluggable Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 3/6] blk-iolatency: make iolatency pluggable Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 4/6] blk-iocost: make iocost pluggable Wang Jianchao (Kuaishou)
2022-02-15 12:37 ` [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular Wang Jianchao (Kuaishou)
2022-02-15 21:26   ` Bart Van Assche
2022-02-16  2:09     ` Wang Jianchao
2022-02-16 18:01       ` Bart Van Assche
2022-02-17  2:56         ` Wang Jianchao
2022-02-15 12:37 ` [RFC V2 6/6] blk: remove unused interfaces of blk-rq-qos Wang Jianchao (Kuaishou)
2022-02-15 13:01 ` [RFC V2 0/6] blk: make blk-rq-qos policies pluggable and modular Chaitanya Kulkarni
2022-02-16  1:43   ` Wang Jianchao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517dddb8-efd6-6b1a-fa1b-eba6f2c93119@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=jbacik@fb.com \
    --cc=jianchao.wan9@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®