From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1D4346AFD for ; Thu, 2 Jul 2026 10:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782988981; cv=none; b=BVU/OQaJE8rMk+ZMOFCTDxaO058wT12Hk3e54omGQs5C23izmIi5uwAqJ6HIPdkg/Nku0jH3eU9GNVBOEvt72SXuYIBiWMF/gcj7vjG9erePS+JtjiSCnU/URsvnaIQ5g/ENEl3FMdHb2Rv6a6Z56mNDpJBZUWj3pWLK8KybqJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782988981; c=relaxed/simple; bh=6sQRIq7b9Zu9XKPDiUd+ggNhyc4hQiLpe1Vw/AVrFSU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B2IYSenkfV8Zu8dp8e2NASq17OjjmNASj7M5Qt/wOMUmADgyTqSBHV7enTHo01SOUWtl/FOnZZ0Aupk4YjqpkxR0NvcD6JMyFHBwyumreRskFnYP7EgGpLl4f9v8gA6aQqpzcK3EpHhCRABlkqkWCkDTL9NmtKS/BRNBr60f4Sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SOQWFAL+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lDuLJHXh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SOQWFAL+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lDuLJHXh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782988979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FqGzQrV1pDX1atAYAe3/sAYqSpXdWp3fwZzPzPU+03Y=; b=SOQWFAL+2CVmVE3Vee8SgPxzv/cGnWvcGgktoOswuKrAMX5TzqjHOR8N0RuMMYYiuYiRfq neygJfQzeU+aAtTn4T3nJnkn1y1/Zw7ptdWqcqMiFyVQ/tj42QghjzVJv57zIWn5rD3wRr wqA0oxaNs3dFmlrSssc54gJa7ZJXX7A= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-UiiWPr1yOhm75RfU65l4FQ-1; Thu, 02 Jul 2026 06:42:58 -0400 X-MC-Unique: UiiWPr1yOhm75RfU65l4FQ-1 X-Mimecast-MFC-AGG-ID: UiiWPr1yOhm75RfU65l4FQ_1782988977 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-474170b59dfso1301797f8f.3 for ; Thu, 02 Jul 2026 03:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782988977; x=1783593777; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FqGzQrV1pDX1atAYAe3/sAYqSpXdWp3fwZzPzPU+03Y=; b=lDuLJHXhKRVycDXq/Bfbc8ZcHeKJ4QO+H5qyx9wV7UAWQndtayWL7sDvDnrFMtWCfO oAq1Fv2LijwjBCPihkPL48+V+RVx5xKaG1nJVplRfXV+Z3Z0MycJChwHy7Jvg6AWx9dM 7F2ap4rdWo+24wcU8dNO8Xr6mRrbLJ7Fwg1q5mqw/jz38YSEsEYZDiqstFzI4oZu4587 6PfIr5vjJ0Zli2C/7unxLVagzpAAciJub4UQIorngRR/iQk8i7/2Jpc/+KgpBxXf3QE7 ddDUMFiF39l2t1869YTFT/+YrHuAUYpfFoeKjdM2ateqHzGZQyle4AvFcIY0ZPrWhoux 0dlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782988977; x=1783593777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FqGzQrV1pDX1atAYAe3/sAYqSpXdWp3fwZzPzPU+03Y=; b=Sk6H0hL3mNkEXOeDpE+wHJu6XJuTQo8HiiNmg/bntMXfaZQvQ86bIZCEYh9kp18kz4 tHCxvIi7eWLAMLMTKBxcui/iwiAc8PbVatH0pTC1h1aeI3HabzSv1zskAX78YMW2zwjt WlIdLJM/YIHkXQif4jBCMfxd++YYo/js+46xQxvy308+/MtNTPprWXNsqHUX1SClsgh5 h7/aD/GJ+9XLldY7qpniwmcvBYGU3C4eGg0986I8AH7lME3InQeipW02+uMxSgQjT8lA vRrZ6nz6BLFT62CnJGrK2r4L3qhhfnoDaJg+CAkQFj6lvve/i0n/OIRMsBBHl/rNK51+ vW0A== X-Forwarded-Encrypted: i=1; AHgh+RrG9w/ZxjQf/ISSiYMITT1iK6gbatcGnelraEioDeHFILXdEqBH+Z27MJZDIWwSzDpJhFkui+OOfPlHjto=@vger.kernel.org X-Gm-Message-State: AOJu0YzVKtZ6HjXx8fMay1fjRLRba416YUMIQifo8IG1h3957KiY30w+ guDUCh2GS/531CVDfW7TM3+oUlo++RmjDC0ZGk3vq+khR7KWltyOLWWWu+WCzFCahF9OXfL1ZpF LLrX5yJT3jBPNe54VCXQt9bRdAkE0KaBs8OKRxSzvBhvCZo28JwrHVitC950jyQ3+Ug== X-Gm-Gg: AfdE7ckjr4UEWfqZgfmxgLId5meuDdFsX+JnOXp5k9LY1Cqzn0toKOpqgCYNtOwgRRA EVxaNS+UBAUZOM6vyOJqKuIkQY2dMwPgGUUBQmBSedDMQaFc6SLyQXSWjVR0GQ7ebNB43kNWl2L gZM1ZKvr++8R3KOVtgbsKhQjVMqZDcXa9l/uJ9dUUtBgsIn9DL/hz2c7ufYwMRo67CWUh0VRkr0 VjfLdW7I4LWt/H4sqUuhOgTgjI3OOegkwtirwWh6WgOXz1gxiNKKpjvdQQKOawAjYdqWKn2BqtP W/8alEnv14A5YcLxX/ImnUdsoX/mTInNoxarQrA+n2ZnYQEsK9sEQjijrMaNYGbfgKSh3XG0arF 9xn1/F3fi9s+z9pN2OVBP/ugW9V+KnLWdQbogWByt3T3MlE6HVwdpin0EJqOO9KUXcSlbeOENTX +OoHeCodZ4HQ== X-Received: by 2002:a5d:5d08:0:b0:476:135a:1349 with SMTP id ffacd0b85a97d-477571cb873mr8078457f8f.6.1782988976770; Thu, 02 Jul 2026 03:42:56 -0700 (PDT) X-Received: by 2002:a5d:5d08:0:b0:476:135a:1349 with SMTP id ffacd0b85a97d-477571cb873mr8078421f8f.6.1782988976326; Thu, 02 Jul 2026 03:42:56 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:2eb7:f61a:75:4534? ([2a0d:3344:5521:6b10:2eb7:f61a:75:4534]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dd94c829sm7517038f8f.24.2026.07.02.03.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:42:55 -0700 (PDT) Message-ID: <517ee2e3-1bc8-48ad-94c7-5d8e47073d5f@redhat.com> Date: Thu, 2 Jul 2026 12:42:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/10] net: emac: use DMA-specific and SMP memory barriers To: Rosen Penev , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , open list References: <20260630041634.284127-1-rosenp@gmail.com> <20260630041634.284127-4-rosenp@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260630041634.284127-4-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/30/26 6:16 AM, Rosen Penev wrote: > @@ -1845,7 +1845,7 @@ static int emac_poll_rx(void *param, int budget) > } > > if (unlikely(budget && test_bit(MAL_COMMAC_RX_STOPPED, &dev->commac.flags))) { > - mb(); > + dma_rmb(); > if (!(dev->rx_desc[slot].ctrl & MAL_RX_CTRL_EMPTY)) { > DBG2(dev, "rx restart" NL); > received = 0; Sashiko geimini thinks the above is not enough for PowerPC: https://sashiko.dev/#/patchset/20260630041634.284127-1-rosenp%40gmail.com > diff --git a/drivers/net/ethernet/ibm/emac/zmii.c b/drivers/net/ethernet/ibm/emac/zmii.c > index a3839cf02ec4..5144ee94a7d2 100644 > --- a/drivers/net/ethernet/ibm/emac/zmii.c > +++ b/drivers/net/ethernet/ibm/emac/zmii.c > @@ -258,8 +258,8 @@ static int zmii_probe(struct platform_device *ofdev) > /* Disable all inputs by default */ > out_be32(&dev->base->fer, 0); > > - printk(KERN_INFO "ZMII %pOF initialized\n", ofdev->dev.of_node); > - wmb(); > + dev_info(&ofdev->dev, "ZMII initialized\n"); The printk change is unrelated and should go in a different patch. /P