From: Mike Galbraith <efault@gmx.de>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Hyunchul Lee <hyc.lee@gmail.com>, Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly
Date: Sun, 12 Sep 2021 04:23:12 +0200 [thread overview]
Message-ID: <51815fbe3e864a0177445b9b17d018a42d603e21.camel@gmx.de> (raw)
In-Reply-To: <425df999d02a62af13da8e77dbed0f2be750cda8.camel@gmx.de>
typing hard.. Thag forget type [patch]
On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>
> rwlock.h specifically asks to not be included directly.
>
> In fact, the proper spinlock.h include isn't needed either,
> it comes with the huge pile that kthread.h ends up pulling
> in, so just drop it entirely.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> ---
> fs/ksmbd/transport_rdma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -20,7 +20,6 @@
> #define SUBMOD_NAME "smb_direct"
>
> #include <linux/kthread.h>
> -#include <linux/rwlock.h>
> #include <linux/list.h>
> #include <linux/mempool.h>
> #include <linux/highmem.h>
>
next prev parent reply other threads:[~2021-09-12 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 2:19 Mike Galbraith
2021-09-12 2:23 ` Mike Galbraith [this message]
2021-09-12 3:00 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51815fbe3e864a0177445b9b17d018a42d603e21.camel@gmx.de \
--to=efault@gmx.de \
--cc=hyc.lee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®