From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7E5470E87 for ; Thu, 23 Jul 2026 11:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805490; cv=none; b=R11QL/7rfG2EITRjRDDIiJdfOgmUmVRPoDZrAoSgKg6QSSKgo2mA4tjwCjhqvpLtEnEoE4BWWhkF0FZdY2pjJ36NQM3a4ijFif3i5qtLMvdkmh/t7RyN2WiopPBbit0c1dzPdkwO9nkKE+6kheJFUnTE5BPtGb7XMHGDyDS3uBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805490; c=relaxed/simple; bh=+Wkaj4UHoena/1Gfc+0sVRsK85mXOaIe+VRpgEhw/+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S3H0ZuaWHg51zAxIHjNERuhqAicIsPFQIu/0Gsp0fyyq+blf01jTp4x16upgaETv/Iufpdz/1usRv2bILdxjcwd2rhhAzZBmGy6IStInkmLVqGCrwMAgHzzCzn96Nn562IGPz9lXO1WY8tLQRBt6smNSddSFaWFyVjc0ZGIxFSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VJwRFtML; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VJwRFtML" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e08baf860so544846a91.2 for ; Thu, 23 Jul 2026 04:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805482; x=1785410282; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5p4lXkdpnCsbltYcC1FVF7UTY1mmokYIoR5useAxszA=; b=VJwRFtMLFtwwxQvdU515qnSw5GDF0xRHaRZPqHLtiYAZ1kKs/fHtLanrE0mejSMCYv fYUmo8IFfMyi0DfmjI31y6BBGF8LGZiOAzYbA/Pg21l+JliazaifAzZ+zOgrDeEbDc+9 duGCgehvS4kJYIUSazDIv3/rw+dDGe17xPpdLXMbsCXTOWiooaM4NydPrUHDSOrJh6rk gdbEbjGzuFugh1qisFhpyK3byWqJyuLWEdInGNquqey3jKjseaL1lTCIO3e15wF8sfi1 QHeuMZyp1/EDh2C78FZO0SqC6AuWcsMKqEP7jgII3qxGmaQuF1S0G0RZnIteAxcsKOte R1sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805482; x=1785410282; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5p4lXkdpnCsbltYcC1FVF7UTY1mmokYIoR5useAxszA=; b=cGfMFTbqnHJZ92sQ2HqRXi869TkHSYtGdKy+91N48NuBjatMPqS8587TRjCOmgpVJg kbZx8itg8dIzKEbhuCWJIRXEgSXLaZmM/KCgoFHRd3Erwdfy3HT6y8CIyZ4P364sZAhv jpbhow3wqEJJrVC8XwJkGj6KAliAS+CGlc75NXdHo4yVNPvKA/mgNVEr82lh0PEZvmKa oE23KBZZdE8Z3OiivePFAe5bb7OotGRgydkFeSjjgEwRCBPjiOD/2i48qbaZYhM1GAjE g6b8VbrGApYMzvlILd5Gum5PbztwtngXvojttg378Uwnka6ZumqjRmCyx21G/h/SKMCU uQhg== X-Forwarded-Encrypted: i=1; AHgh+Rpnqq+Dg/INoBOU8fsfTdO01QMbPf7zEk5mnK9tAGkWGCksieq2JTr0gO2aJYDd7a5uN74MTasI7gs7vKY=@vger.kernel.org X-Gm-Message-State: AOJu0YzyVRRPubAhHg4C9PledN5gAMgfoXmoRY9XIVN4nVsueHJwK4dP KsqZ9vUY8DIAvYci8P1tpAG2m+gY8tr7wG5BLvNNaa0Kn3NplW5Ggnxf X-Gm-Gg: AR+sD11Lm3ElhmTyVZ6DaUV+/NHcJCZBxNFUWpT6Trq7QPpwIxLked1nLs7dfichmNb j5MwMVlkdwnkaqoak5rJ8zzN2Md3yb+ZVnJ9dBJDrPo7lDoY5DAE5YLcGIYsWRXAbj5nuve6jM8 8gV/UkBuNmGr3WF+VW7tXROaC2fHRzte/KXouiOpD2cxekaUQcBmQLNKz2FrYF91vp6Co5DKCwd g64+/fyQZPQ6tnwIQCz4BGSDe8q7ye6SgxZZBl+WLGwMxoL+62x0f4wzHKUTXsc/A9jD7fjlik/ 6lDFn6LuTt9yjwI0DjWJ5+XOkuYk3aYfKNZWjOo98Uyb+OB2B49HI3iUTIoVi2ntGANXRT8V4Ol h4+KuhyXVvWwUICRtJs0RIhHk4mB9oLSc1tYC0GMxq+a9SlO4ZtL9p6opBweFjDrGmZ+QvXlDle 3bDovwHmLc5gJHj5P0WSTqb4ed X-Received: by 2002:a17:90b:1d48:b0:387:e0db:3d8e with SMTP id 98e67ed59e1d1-38ec665050cmr2866538a91.41.1784805481916; Thu, 23 Jul 2026 04:18:01 -0700 (PDT) Received: from [10.22.68.205] ([118.201.124.118]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38ea5966676sm1591924a91.2.2026.07.23.04.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 04:18:01 -0700 (PDT) Message-ID: <51865f65-7b75-40a8-b7ba-7029065f5840@gmail.com> Date: Thu, 23 Jul 2026 19:17:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] blk-cgroup: remove unused blk_queue_for_each_rl stub To: Tao Cui , axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, tj@kernel.org, yukuai@kernel.org, yangxiuwei@kylinos.cn, cuitao@kylinos.cn References: <20260717102049.2080768-1-cui.tao@linux.dev> Content-Language: en-US From: Tang Yizhou In-Reply-To: <20260717102049.2080768-1-cui.tao@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/7/26 6:20 pm, Tao Cui wrote: > From: Tao Cui > > blk_queue_for_each_rl() was added by commit a051661ca6d1 ("blkcg: > implement per-blkg request allocation") to iterate over the root request > list and per-blkg request lists for the legacy (non-blk-mq) request > allocation path. The request_list code, including q->root_rl from > struct request_queue, was later removed in 2018 by commit db6d99523560 > ("block: remove request_list code"). > > The macro definition left behind in the !CONFIG_BLK_CGROUP fallback > branch of the private block/blk-cgroup.h header now references the > removed q->root_rl field, and has no callers in-tree (it would fail to > compile if expanded, so it cannot have any out-of-tree users either). > > Remove the dead stub. > > Signed-off-by: Tao Cui > --- > block/blk-cgroup.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h > index 615390f751aa..6a309d2d3db5 100644 > --- a/block/blk-cgroup.h > +++ b/block/blk-cgroup.h > @@ -500,9 +500,6 @@ static inline void blkg_put(struct blkcg_gq *blkg) { } > static inline void blk_cgroup_bio_start(struct bio *bio) { } > static inline bool blk_cgroup_mergeable(struct request *rq, struct bio *bio) { return true; } > > -#define blk_queue_for_each_rl(rl, q) \ > - for ((rl) = &(q)->root_rl; (rl); (rl) = NULL) > - > #endif /* CONFIG_BLK_CGROUP */ > > #endif /* _BLK_CGROUP_PRIVATE_H */ Reviewed-by: Tang Yizhou -- Best Regards, Yi