From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: quic_tsoni@quicinc.com, quic_shashim@quicinc.com,
quic_kaushalk@quicinc.com, quic_tdas@quicinc.com,
quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com,
kernel@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: Add base SM4450 QRD DTS
Date: Thu, 27 Jul 2023 09:59:10 +0200 [thread overview]
Message-ID: <518770c2-05ad-a2a2-4e73-7ceb30687614@linaro.org> (raw)
In-Reply-To: <f974f48a-05b0-530d-25a0-7ccf1b1ad113@linaro.org>
On 27.07.2023 08:56, Krzysztof Kozlowski wrote:
> On 27/07/2023 04:35, Tengfei Fan wrote:
>> Add DTS for Qualcomm QRD platform which uses SM4450 SoC.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 18 ++++++++++++++++++
>> 2 files changed, 19 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 337abc4ceb17..db805d0929c8 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -186,6 +186,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdx75-idp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm6115p-lenovo-j606f.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> new file mode 100644
>> index 000000000000..04ad1dd4285a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> @@ -0,0 +1,18 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "sm4450.dtsi"
>> +/ {
>> + model = "Qualcomm Technologies, Inc. SM4450 QRD";
>> + compatible = "qcom,sm4450-qrd", "qcom,sm4450";
>> +
>> + aliases { };
>> +
>> + chosen {
>> + bootargs = "console=hvc0 earlycon=hvc0 hvc_dcc.enable=1 cpuidle.off=1";
>
> No earlycon, no hvc.enable (there is no such parameter), no cpuidle.off
> (again don't add fake stuff). So the only suitable argument is console,
> but this should be actually used via stdout path, although it seems
> there is no device node for such usage?
hvc totally comes from Qualcomm downstream and all the Gunyah
shenanigans..
Tengfei, please ensure the patches are tested against linux-next
with no additional changes or modules, with a clean Linux userspace
(or at least a ramdisk).
Konrad
next prev parent reply other threads:[~2023-07-27 8:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 2:35 [PATCH v2 0/6] soc: qcom: Add support for SM4450 Tengfei Fan
2023-07-27 2:35 ` [PATCH v2 1/6] dt-bindings: qcom,pdc: add qcom,sm4450-pdc compatible Tengfei Fan
2023-07-27 6:52 ` Krzysztof Kozlowski
2023-07-27 2:35 ` [PATCH v2 2/6] dt-bindings: arm: qcom: Document SM4450 SoC and boards Tengfei Fan
2023-07-27 6:52 ` Krzysztof Kozlowski
2023-07-27 2:35 ` [PATCH v2 3/6] arm64: dts: qcom: Adds base SM4450 DTSI Tengfei Fan
2023-07-27 6:53 ` Krzysztof Kozlowski
2023-07-27 7:38 ` Tengfei Fan
2023-07-27 2:35 ` [PATCH v2 4/6] arm64: dts: qcom: Add base SM4450 QRD DTS Tengfei Fan
2023-07-27 6:56 ` Krzysztof Kozlowski
2023-07-27 7:59 ` Konrad Dybcio [this message]
2023-07-27 8:49 ` Tengfei Fan
2023-07-27 13:08 ` Konrad Dybcio
2023-07-28 0:49 ` Tengfei Fan
2023-07-28 1:41 ` Trilok Soni
2023-07-27 8:27 ` Tengfei Fan
2023-07-27 8:50 ` Krzysztof Kozlowski
2023-07-27 9:02 ` Tengfei Fan
2023-07-27 2:35 ` [PATCH v2 5/6] dt-bindings: arm: qcom,ids: add SoC ID for SM4450 Tengfei Fan
2023-07-27 6:57 ` Krzysztof Kozlowski
2023-07-27 7:57 ` Tengfei Fan
2023-07-27 2:35 ` [PATCH v2 6/6] soc: qcom: socinfo: add SM4450 ID Tengfei Fan
2023-07-27 6:57 ` Krzysztof Kozlowski
2023-07-27 7:58 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518770c2-05ad-a2a2-4e73-7ceb30687614@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®