From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E63DC335579 for ; Fri, 9 Jan 2026 09:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767952731; cv=none; b=VRAnqya8ZCHrbxSqHeTIRDS4ZO31lsUAkt+bR3Z1GD2zZEWsYa7/rdLCCDSczW/SEUpL6fsz8Lqol7zFKvA7tINWlpoU/ZuXgLiogVpBwurSBGq26zIwoaaO34wb4T4bbutAIMw4Eyff2WATjvXB34UWrQ5oqPC0kG1KBqatN4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767952731; c=relaxed/simple; bh=w9kmQhr3nHgHIYohpbkrMCLLczT0ETWtT6hWFY16hO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p2HhoC4sLBhZiRzpFUJBdcWzEnhKSziA7JrrXVw5TnYbWM6tG0ke5HnE8yS4qymXoy6wB8UwrS7hZktjNS9gkwlmbDVrg4w5VaCZQDaX2EIicudLutdx9ZVmed+dKTlfBDKsEmnr4/VFBK0l8jHTITbm3Bd8Ul0QlQ/tNf6hNMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nbEMBRmb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YEq3ZIB1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nbEMBRmb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YEq3ZIB1" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6096cPnB1953482 for ; Fri, 9 Jan 2026 09:58:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +6GsV1dZl9kT6hAIcgcGDP9q3jtz6hmBU4iyqq4JbUw=; b=nbEMBRmbowbFIPrz LxLtlsDhO3Nko65fxamFApMmkJMr9DFazbkvVpDaAPrjon+BVwBbPNkvKLGcJXG7 U34k75zv7tNcJgXthddZ2o/ubrp7bV4Au1sGif3KXRLQjGjfuPHALpLTXXy1lMha /YZvW4FX6b0Ipr6E8rDaLqhIBh7K7T7/MmSl2OTOFfuB/u6ldq+7VX+6BXdIZ32P tmuObfPVE0q7YzL0NUDys0qxqRjG3A7Wh4whHAZCvhOqTeh+NP7L5yqrH5cyM0sA E0mmN/Zd0vY9Uu34VbbppXr5txc3b2VqnYC95D5CH8FgRlOQ7cPxXVAuL7EjnTUJ fzYTPQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjfdaavx9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 09:58:47 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee07f794fcso11720641cf.2 for ; Fri, 09 Jan 2026 01:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767952727; x=1768557527; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+6GsV1dZl9kT6hAIcgcGDP9q3jtz6hmBU4iyqq4JbUw=; b=YEq3ZIB13WsadbGD5mWf0Pc+S8A+ZBmLpBuC2TB3rIuhthVbdZ6TC03z/LrW5QLhob d/GcNRbv+VJgQ3rrRyrDqdVp4qgc36oUZp7A4Sh4m+c42i5VMw27lexWvE8CP3IIV1WN dUYFHV/7xLeaT0l4xo0wKbhvk0n2JZlqFdr9DN5i9PuF2zxSvZOKpYkgk1XOBV3C5b0D C17tzPzmPDtylzfnB7pfmcQUYUPXEwewD1AqeSgxbeSDGl1Ed1d64lUX0pVJxOilWR36 Z2hepy4c2W+HcLRXXUgT7ayykFjgOH+eAHP5puDi7BIiDPcqEjU1nvz/ImyfOFRCKuEN 7p3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767952727; x=1768557527; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+6GsV1dZl9kT6hAIcgcGDP9q3jtz6hmBU4iyqq4JbUw=; b=XyE8KDmtpT8OlOq+iMpmkdVEtL9hTjbujeVJhZmQ7yDIP7oBtRuaIHiRxBZBJQt2Wy AanAYuHEaSmzmNvrHd5xfM4JI6cnM3fgJnRIupB5aIGy5lGVr1KYFg1+UD2gLkLJ/N84 qLIugaSHXir0XHTKnlQO/i8xPKaeoDKFnz9DhDY/cRng2TF/aq2oJjLQIPZlgNNWNO3V YnY5ou0mv3cW/9mIl+jajsCMd05MAuUaxaq28QpR2WzGAbfsbQ34EZpGVC3xicoshi4g FVr+veZe/N01rIxCZbM1TfKez3j4VuUDB82TsRs6xDsVPouXwHp7Bgv5GqjSg30rSsCS hOeA== X-Forwarded-Encrypted: i=1; AJvYcCUHaXHi0qNjMds7gAKSNdRguQ8Mr0ClYgJsNNs3LCaVxONmXjKYmb1QweNglKZBVoSNfZbL8qt7LV7J2+E=@vger.kernel.org X-Gm-Message-State: AOJu0YwwSJMYDpnL1amuyYt8gfWIB8iTGiHpR7BkdCopVrVGCThOoK5O NR1da8KyyLGdmCPSCQMVC0JDqUbKkq2HmVJnIUTdk83CXajG+y7UckribNL8gl+XUCJVR+kwHs/ 9ri/05g8xe9VOzDDbD8fWAp/ygBckHIwn3FYZBO/a0fstYHEZqMCsIkvsVG/QBXuOHIecsjQJB6 Y= X-Gm-Gg: AY/fxX4kBb/R7dNjbXp/bl7v3IH4l5D5Z4dnfRieTDOWhd/MDKF8JZ9mhLcm3dxXRnE O6QlAzw0FxW7GlwdGhyS1HZ/l8odAonPWNA2Ch4nPUBqFbW+YEk1ECHwcr6Sfk8JMRUdepwX5ax H/2g0ejmAgMIl/arxYEO6SGQDjgoqzSEXBgftc935pa6T0cySHmMGwi7l34ksnX5k/3vIIOVQKP wGGmeM3sQPBnOeTlcLQ+T5qq3e1Va2636+ZEtV24LvHUzrToj+e+x4UIUk5upHZ9xsgmAwHXS1W UhYi6rQAU7VZBSGh3oaN/+D5drL0E/bqMpp/CNzNe3LwB4TMEVhw40B7eS3pLml0iWvvyIQOiRZ ZHI9kEBcGQJCpMq/2Sg+7JdQEf1zFjZvZf/ruS1Jj1gBpEgxXjxBZqkMYU/ZbEAJ617g= X-Received: by 2002:a05:622a:2cb:b0:4f1:b580:fba8 with SMTP id d75a77b69052e-4ffb48d3b42mr101362361cf.3.1767952726953; Fri, 09 Jan 2026 01:58:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8E29q2sylMSnFtakEPUUAJV/nWkQMkdMPAuEzQOehQkivxBC9D4DqYRshBbwS0yUI9YREWg== X-Received: by 2002:a05:622a:2cb:b0:4f1:b580:fba8 with SMTP id d75a77b69052e-4ffb48d3b42mr101362231cf.3.1767952726379; Fri, 09 Jan 2026 01:58:46 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a564e05sm1099326566b.65.2026.01.09.01.58.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 01:58:45 -0800 (PST) Message-ID: <5187dc04-a1a1-4537-9c80-aaa100dd0033@oss.qualcomm.com> Date: Fri, 9 Jan 2026 10:58:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/dp: Correct LeMans/Monaco DP phy Swing/Emphasis setting To: Yongxing Mou , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260109-klm_dpphy-v1-1-a6b6abe382de@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260109-klm_dpphy-v1-1-a6b6abe382de@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ue1ciaSN c=1 sm=1 tr=0 ts=6960d157 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=QeOGaa-XQxNk_RVdTJwA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: U1v-8fyX_Kf-VHgUQXe4Sohk-pjI-aWx X-Proofpoint-GUID: U1v-8fyX_Kf-VHgUQXe4Sohk-pjI-aWx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA3MSBTYWx0ZWRfX3Sg1zQhnJKNe lTtw5Qac+qMjj3D2C2+GPRCwNqzi0Wwl1sklZp8ogjkc517MbLFItxkciCShmYZ8ZfL3uYTl/20 cweayKvKiVgLtPfou6mvoDuy4vc56nnHwPwUg1CaTYWxj5yZwHbMoYfpqqmcZtHpJHH5AcldV5o LJu3LPWAidk5L0zK3ujjzPJ3mEHT1gg3LzRihspi15W9yjkOd2D1Abjgc+5gGmVNGJW2Mu5CJll 2T6tZrhdA2Yq9a+xfsT2UaJ1EbVHBI6NG8LQHQ/Nc1o9mZIj1DNG6aqsr0H/TuMMXrA6KwCNs6r ve0NA2jmUzzidNpoq/d7sLYT+WFcF/OodVJEhi8fRGvChJTnpWH0mtY6rAOpbJiqv5X5LumzXJg oYd8DM1A2y7tqPoHMyS3zs+5OLQ+uqp/aUr+sIqhXWSE02OKWQ4CHmE679Xw4qLYdb0dkFfwJFv 5PHj1VZ1EyD3e8ltnig== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090071 On 1/9/26 9:30 AM, Yongxing Mou wrote: > Currently, the LeMans/Monaco DP PHY operates in DP mode rather than eDP > mode. Per the PHY HPG, the Swing and Emphasis settings have been corrected > to the appropriate DP-mode values. > > Additionally, the HPG specifies that the LDO value should be set to 0 when > in DP mode. These misconfigurations can lead to link training failures on > certain dongles. > > Signed-off-by: Yongxing Mou > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 27 ++++++++++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 13feab99feec..5b0d774bd715 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -122,6 +122,13 @@ static const u8 dp_swing_hbr_rbr[4][4] = { > { 0x1f, 0xff, 0xff, 0xff } > }; > > +static const u8 dp_swing_hbr_rbr_v1[4][4] = { > + { 0x07, 0x0f, 0x16, 0x1f }, > + { 0x11, 0x1e, 0x1f, 0xff }, > + { 0x16, 0x1f, 0xff, 0xff }, > + { 0x1f, 0xff, 0xff, 0xff } > +}; For these platforms, I see 4 tables of settings: (Low/High) Swing/Pre-em for (Low/High) HBR None of them exactly match your change [...] > - ldo_config = edp->is_edp ? 0x0 : 0x1; > + ldo_config = !edp->is_edp ? 0x0 : 0x1; You'll notice that this is further wrong, because for eDP, it should be 0x81 at low-swing-high-HBR and 0xc1 at low-swing-low-HBR, and 0 at both cases of high-swing Please split the LDO change into a separate commit because it touches more platforms Konrad