From: Christopher Bostic <cbostic@linux.vnet.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
rostedt@goodmis.org, mingo@redhat.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
alistair@popple.id.au, benh@kernel.crashing.org,
"Edward A . James" <eajames@us.ibm.com>,
Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master
Date: Sun, 9 Apr 2017 16:04:59 -0500 [thread overview]
Message-ID: <518e0abc-f1da-2ca0-fa44-6802e2b74c71@linux.vnet.ibm.com> (raw)
In-Reply-To: <5d173f9c-e01c-6093-16ab-d114857009b2@infradead.org>
On 4/5/17 11:35 AM, Randy Dunlap wrote:
> On 04/04/17 19:06, Christopher Bostic wrote:
>> From: Chris Bostic <cbostic@linux.vnet.ibm.com>
>>
>> Implement a FSI master using GPIO. Will generate FSI protocol for
>> read and write commands to particular addresses. Sends master command
>> and waits for and decodes a slave response.
>>
>> Includes changes from Edward A. James <eajames@us.ibm.com> and Jeremy
>> Kerr <jk@ozlabs.org>.
>>
>> Signed-off-by: Edward A. James <eajames@us.ibm.com>
>> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
>> Signed-off-by: Chris Bostic <cbostic@linux.vnet.ibm.com>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> drivers/fsi/Kconfig | 11 +
>> drivers/fsi/Makefile | 1 +
>> drivers/fsi/fsi-master-gpio.c | 610 ++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 622 insertions(+)
>> create mode 100644 drivers/fsi/fsi-master-gpio.c
>>
>> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
>> index 04c1a0e..9cf8345 100644
>> --- a/drivers/fsi/Kconfig
>> +++ b/drivers/fsi/Kconfig
>> @@ -9,4 +9,15 @@ config FSI
>> ---help---
>> FSI - the FRU Support Interface - is a simple bus for low-level
>> access to POWER-based hardware.
>> +
>> +if FSI
>> +
>> +config FSI_MASTER_GPIO
>> + tristate "GPIO-based FSI master"
>> + depends on FSI && GPIOLIB
> depends on FSI is redundant since "if FSI" does the same thing.
Hi Randy,
Thanks for the feedback, will correct.
-Chris
>> + ---help---
>> + This option enables a FSI master driver using GPIO lines.
>> +
>> +endif
>> +
>
next prev parent reply other threads:[~2017-04-09 21:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 2:05 [PATCH v5 00/23] FSI device driver implementation Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 01/23] drivers/fsi: Add fsi master definition Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 02/23] drivers/fsi: Add slave definition Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 03/23] drivers/fsi: Add empty master scan Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 04/23] drivers/fsi: Add crc4 helpers Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 05/23] drivers/fsi: Add slave & master read/write APIs Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 06/23] drivers/fsi: Set up links for slave communication Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 07/23] drivers/fsi: Implement slave initialisation Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 08/23] drivers/fsi: Set slave SMODE to init communication Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 09/23] drivers/fsi: scan slaves & register devices Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 10/23] drivers/fsi: Add device read/write/peek API Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 11/23] drivers/fsi: Add master unscan Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 12/23] drivers/fsi: Add documentation for GPIO bindings Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 13/23] drivers/fsi: Add client driver register utilities Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 14/23] drivers/fsi: Add sysfs files for FSI master & slave accesses Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 15/23] drivers/fsi: expose direct-access slave API Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 16/23] drivers/fsi: Add tracepoints for low-level operations Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 17/23] drivers/fsi: Add error handling for slave communication errors Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 18/23] drivers/fsi: Document FSI master sysfs files in ABI Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master Christopher Bostic
2017-04-05 16:35 ` Randy Dunlap
2017-04-09 21:04 ` Christopher Bostic [this message]
2017-04-05 2:06 ` [PATCH v5 20/23] drivers/fsi/gpio: Add tracepoints for GPIO master Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 21/23] drivers/fsi: Add SCOM FSI client device driver Christopher Bostic
2017-04-05 16:35 ` Randy Dunlap
2017-04-09 21:06 ` Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 22/23] drivers/fsi: Add hub master support Christopher Bostic
2017-04-05 16:36 ` Randy Dunlap
2017-04-09 21:07 ` Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 23/23] drivers/fsi: Use asynchronous slave mode Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518e0abc-f1da-2ca0-fa44-6802e2b74c71@linux.vnet.ibm.com \
--to=cbostic@linux.vnet.ibm.com \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®