From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751899AbcFULkY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 07:40:24 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:49304 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751099AbcFULjb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 07:39:31 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit
Date: Tue, 21 Jun 2016 13:41:20 +0200
Message-ID: <5191137.P6HbgXDjAh@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <yq1eg7r5oq5.fsf@sermon.lab.mkp.net>
References: <20160615204231.3784044-1-arnd@arndb.de> <4878482.cSGU6mK9NX@wuerfel> <yq1eg7r5oq5.fsf@sermon.lab.mkp.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:cBJdeSHfnjmViqHLmNBlby2CakVyglIA5Vx736K108lrLoqqoxN
 X26Ec7G1zu1cOv99YbxcqE4H30HuMg9VxhZVnLyzvMQAkJZRTxXdhM6Rle+I1S7EWBwiH4y
 53xNMZVbVCET+FoiWmFsRgRKULO/8YynKzV5jfP4T2qI90kWBoUZ6UUvqNWDm1dSBFeAjQo
 5L58OiC4zwS022jda3a+Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:CjFGK2cICzk=:USLRv2GH7vvnXt5Enuhj+r
 Wcz/ZnOOc/K7ZgS4hi4/K3EtwYjpwftOXGeP/H9EL6glZ9wIgwBTdi9KuYW5JV9blf6sXXHoX
 r7Cnw3Whf/F8uaG6G3H5TuseNn/EDfpwx4dKFdOIL0jU3TEg4o6jpLzHu/iH5zLE0RDl0xoon
 J+s49RsWNfJ8Tk7IwpdsTyEKRV1Q+GQwkJV3KavJBcycH3Q5zqOnKyG8cTGt0x5OSjMTtGxH6
 4miFGVatAvhjnCod344FCOydNYEbOd54yGe+pHebnawKXwlMM05WaAy67I9yDxXZBn7O56jUp
 A5fiV310wYuWwlnf14OopUMClJfboT6LpybCHE9mAhqZtyuUIEdZ0A4+Wau66iKIY2/K6F3wx
 FLGKqsYVINpyOytklIb3R33qXk4YlJL2sVs/ynulQl1cCwc4tiUAJdHwgY9wWg2hEAtKzowbl
 /gJHOhcPLZ/6nA4XUL++mNQdTOQ5MRlkGqoHHjaro+tto1eongGE2GCuBBpFAh4/yPe4wYfzm
 xNCrfUfzH2mk2GL4qX76wS0qGISeJcZXbiU+UYQhxUsWvEnT5IdL7/9Rd8oRn+r7YTqxSretm
 lGbNhhwuhOnM1tQ3RuYmQZLYjbzm+HiuQWcy6neKfp92eluL9PjFUA8bzVf3rSrLQ1qtSaLh0
 Vp0ffhUH4SHbsze6ahCkNBn1LnUwVYqFixrE3r+XFaTovLr+3D851cWxwHiAvhG9oXkHe7evZ
 TDkOlHm28seDQIW6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, June 20, 2016 9:12:50 PM CEST Martin K. Petersen wrote:
> >>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
> 
> As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints
> that with the correct format. The change to use no_printk()
> 
> [...]
> 
> +       dprintk("wd7000_biosparam: dev=%s, size=%lld, ",
> +               bdevname(bdev, b), (s64)capacity);
> 
> s64?
> 
> Why not unsigned long long like we usually do with sector_t?

The printk() was using %d as the format string, printing it
as a signed number, so I did not change it.

Using %llu makes sense though, I've resent it like that.

	Arnd