mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Crispin <blogic@openwrt.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl/lantiq: Free mapping configs for both pin and groups
Date: Wed, 15 May 2013 12:36:06 +0200	[thread overview]
Message-ID: <51936516.1080305@openwrt.org> (raw)
In-Reply-To: <1368543638-3299-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

On 14/05/13 17:00, Laurent Pinchart wrote:
> When creating mappings from DT both pin config and group config mappings
> are allocated. Free them both when destroying the mappings.
>
> Signed-off-by: Laurent Pinchart<laurent.pinchart+renesas@ideasonboard.com>
Acked-by: John Crispin <blogic@openwrt.org>


> ---
>   drivers/pinctrl/pinctrl-lantiq.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-lantiq.c b/drivers/pinctrl/pinctrl-lantiq.c
> index 615c500..d22ca25 100644
> --- a/drivers/pinctrl/pinctrl-lantiq.c
> +++ b/drivers/pinctrl/pinctrl-lantiq.c
> @@ -52,7 +52,8 @@ static void ltq_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
>   	int i;
>
>   	for (i = 0; i<  num_maps; i++)
> -		if (map[i].type == PIN_MAP_TYPE_CONFIGS_PIN)
> +		if (map[i].type == PIN_MAP_TYPE_CONFIGS_PIN ||
> +		    map[i].type == PIN_MAP_TYPE_CONFIGS_GROUP)
>   			kfree(map[i].data.configs.configs);
>   	kfree(map);
>   }


  reply	other threads:[~2013-05-15 10:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 15:00 Laurent Pinchart
2013-05-15 10:36 ` John Crispin [this message]
2013-05-15 11:29 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51936516.1080305@openwrt.org \
    --to=blogic@openwrt.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®