From: Dmitry Osipenko <digetx@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] clk: Add enable-state column to clk summary
Date: Fri, 13 Nov 2020 12:04:29 +0300 [thread overview]
Message-ID: <519526ca-fd50-f8c5-6ea9-dba6d356f0e9@gmail.com> (raw)
In-Reply-To: <160525551074.60232.7613044083282105115@swboyd.mtv.corp.google.com>
13.11.2020 11:18, Stephen Boyd пишет:
> Quoting Dmitry Osipenko (2020-11-04 08:56:31)
>> Add "enable state" column to the clk summary. It's handy to know actual
>> hardware state of all clocks for debugging purposes. In conjunction with
>> clk_ignore_unused, this tells us what unused clocks are left on after
>> bootloader without disabling the clocks.
>
> Should it be called "boot state" then? That idea sounds OK to me.
>
>> It's also s useful debugging
>
> Stray 's' here.
>
>> information for cases where firmware touches clocks.
>
> Care to explain more? Presumably you mean when firmware is modifying clk
> state without notifying the kernel?
This is exactly what I meant.
> In which case it should be called
> "hardware enable" or something like that and be a "Y/N/?" value
> depending on if the value can be read or not and if it is enabled or not?
Indeed, I like the "hardware enable", thank you for the suggestion. The
"Y/N/?" suggestion is also good.
I'll prepare v2, thank you for the review!
prev parent reply other threads:[~2020-11-13 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 16:56 Dmitry Osipenko
2020-11-13 8:18 ` Stephen Boyd
2020-11-13 9:04 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519526ca-fd50-f8c5-6ea9-dba6d356f0e9@gmail.com \
--to=digetx@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®