mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: lenovo_se10_wdt: Add support for SE10 Gen 2 platform
Date: Mon, 04 May 2026 09:13:19 -0400	[thread overview]
Message-ID: <51993cb1-f032-488e-92a2-2b2e65af767c@app.fastmail.com> (raw)
In-Reply-To: <d9beb8ff-0ffe-42ff-8249-e12f1a4c2e2c@roeck-us.net>

Hi Guenter,

On Sun, May 3, 2026, at 5:53 PM, Guenter Roeck wrote:
> On 4/28/26 05:49, Mark Pearson wrote:
>> The Lenovo SE10 Gen 2 platform uses a watchdog chip from the same family.
>> Watchdog functionality is the same, so update the driver with the new chip
>> ID.
>> 
>> Add the Gen 2 MTM's to enable support on the platform.
>> 
>> Tested on SE10 G2.
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ... but you might want to have a look at the AI review.
> It appears that the driver has some issues.
>
> https://sashiko.dev/#/patchset/20260428124954.1193450-1-mpearson-lenovo%40squebb.ca
>
> Patches welcome ...
>
Thanks for the review.

Ack on the AI review patch - thanks for flagging that as I was unaware of those (I'd heard about sashiko.dev - but hadn't thought to check it for results).
It looks like a valid/good thing to fix. I assume it's OK if I push that as a separate patch rather than combining it with this?

Mark

  reply	other threads:[~2026-05-04 13:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 12:49 Mark Pearson
2026-05-03 21:53 ` Guenter Roeck
2026-05-04 13:13   ` Mark Pearson [this message]
2026-05-04 14:16     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51993cb1-f032-488e-92a2-2b2e65af767c@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®