mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shubhang <sh@gentwo.org>
To: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	 Juri Lelli <juri.lelli@redhat.com>,
	 Vincent Guittot <vincent.guittot@linaro.org>,
	 Dietmar Eggemann <dietmar.eggemann@arm.com>,
	 Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>,  Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	 K Prateek Nayak <kprateek.nayak@amd.com>,
	 "Christoph Lameter (Ampere)" <cl@gentwo.org>,
	 Shubhang Kaushik <shubhang@os.amperecomputing.com>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/fair: Prefer waker CPU for reciprocal sync wakeups
Date: Fri, 24 Jul 2026 09:08:39 -0700 (PDT)	[thread overview]
Message-ID: <519ca485-e2b5-a258-e1e4-b45c7feed57f@gentwo.org> (raw)
In-Reply-To: <60a584c5-25ac-4077-a725-a2f9ee74318d@linux.ibm.com>

Hi Vineeth,

On Fri, 24 Jul 2026, Madadi Vineeth Reddy wrote:

> On 23/07/26 04:20, Shubhang Kaushik (Ampere) wrote:
>> +			    READ_ONCE(p->last_wakee) == current &&
>> +			    prefer_sync_pair_cpu(p, cpu))
>> +				return cpu;
>
>
> The difference is SMT. POWER10/11 are SMT8: stacking there puts the pair on one thread while up to
> seven siblings on the same core sit idle, sharing the same LLC.
>
> So instead of returning the waker's CPU, I'm looking at letting the waker's *core* count as idle
> when the waker's runqueue has a single runnable task, so the wakee lands on a sibling thread.

Thanks for the review, the distinction makes sense.

In the case of non-SMT, the benefit I am seeing comes from stopping 
SIS from moving the reciprocal WF_SYNC wakee away from the wake-affine 
target.

For v3, my plan is to keep this scoped to that non-SMT case under 
the existing SD_WAKE_AFFINE path and fold in Prateek's suggested 
cleanups. Would still wait for Christian/Prateek's SMT numbers to make 
sure this does not need additional SMT handling in this series.

Regards,
Shubhang Kaushik

  reply	other threads:[~2026-07-24 16:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 22:50 Shubhang Kaushik (Ampere)
2026-07-23  3:48 ` K Prateek Nayak
2026-07-24  0:35   ` Shubhang
2026-07-23  6:11 ` Christian Loehle
2026-07-23  6:29   ` K Prateek Nayak
2026-07-24 12:50 ` Madadi Vineeth Reddy
2026-07-24 16:08   ` Shubhang [this message]
2026-07-29 18:06 ` Shubhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519ca485-e2b5-a258-e1e4-b45c7feed57f@gentwo.org \
    --to=sh@gentwo.org \
    --cc=bsegall@google.com \
    --cc=cl@gentwo.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=shubhang@os.amperecomputing.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vineethr@linux.ibm.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®