mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Shrikanth Hegde <sshegde@linux.ibm.com>,
	maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Cc: mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org,
	msuchanek@suse.de, ritesh.list@gmail.com, harshpb@linux.ibm.com,
	gautam@linux.ibm.com, amachhiw@linux.ibm.com,
	venkat88@linux.ibm.com, nnmlinux@linux.ibm.com,
	mkchauras@gmail.com, "R.T.Dickinson" <rtd2@xtra.co.nz>,
	mad skateman <madskateman@gmail.com>,
	Damien Stewart <hypexed@yahoo.com.au>,
	Christian Zigotzky <info@xenosoft.de>
Subject: Re: [PATCH v2 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels
Date: Tue, 10 Nov 2026 18:39:52 +0100	[thread overview]
Message-ID: <519cb2b2-5c3d-a75e-6919-d5d0784bae63@xenosoft.de> (raw)
In-Reply-To: <20261110053238.3794500-1-sshegde@linux.ibm.com>

On 10/11/26 06:32, Shrikanth Hegde wrote:
> Christian Zigotzky had reported that preemptible kernels don't boot on
> his FSL Cyrus+ board. The board freezes on running either full/lazy
> preemption and has been an issue for a while now (years!).
>
> https://lore.kernel.org/all/b897b0fd-90f2-4215-bcd4-3714e497d773@xenosoft.de/#t
>
> After 7.0, there is only preempt=full/lazy which removed the
> preempt=none/voluntary workaround used to mask the issue. There was
> challenge is getting the console logs which made the fixes difficult since
> one couldn't know where the issue is.
>
> Thanks to Michal for helping in getting the logs. That pointed at few
> places where the issue could be. This series is an attempt at fixing
> those.
>
> Christian, I haven't taken the tested-by tag since patches have
> changed quite a bit.
> Please help in *testing* the patches again.
>
> v1->v2:
> - Re-order to avoid preempt count dance (Narayana Murty N)
> - Do only hard_irq_disable on PPC64 to avoid second warning. On PPC32
>    use local_irq_disable to acheive the same. (Ritesh Harjani)
>
> v1: https://lore.kernel.org/all/20260928110411.844582-1-sshegde@linux.ibm.com/
>
> New API ppc_hard_irq_disable could potentially be used in other places.
> There is similar pattern of doing both local and hard irq disable and
> likely not all callsites need both. But it is a larger effort and due to
> my time limit, it will be taken up subsequently.
>
> Shrikanth Hegde (3):
>    powerpc/irq: Add ppc_hard_irq_disable()
>    KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts
>    KVM: PPC: Use ppc_hard_irq_disable before guest entry
>
>   arch/powerpc/include/asm/hw_irq.h | 17 +++++++++++++++++
>   arch/powerpc/kvm/booke.c          |  7 +++++--
>   arch/powerpc/kvm/powerpc.c        | 14 +++-----------
>   3 files changed, 25 insertions(+), 13 deletions(-)
>

I patched the RC2 of kernel 7.4 with these three new patches and 
compiled it again [1]. The patched RC2 preempt kernel works with KVM HV 
without any problems.

Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>

Thanks a lot for your help! :-)

[1] https://github.com/chzigotzky/kernels/releases/tag/v7.4.0-rc2-2

-- 
Sent with BrassMonkey 35.0.2 (https://github.com/chzigotzky/Web-Browsers-and-Suites-for-Linux-PPC/releases/tag/BrassMonkey_35.0.2)


      parent reply	other threads:[~2026-11-10 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  5:32 Shrikanth Hegde
2026-11-10  5:32 ` [PATCH v2 1/3] powerpc/irq: Add ppc_hard_irq_disable() Shrikanth Hegde
2026-11-10  5:32 ` [PATCH v2 2/3] KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts Shrikanth Hegde
2026-11-10  5:32 ` [PATCH v2 3/3] KVM: PPC: Use ppc_hard_irq_disable before guest entry Shrikanth Hegde
2026-11-10 17:39 ` Christian Zigotzky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519cb2b2-5c3d-a75e-6919-d5d0784bae63@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=amachhiw@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=gautam@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=hypexed@yahoo.com.au \
    --cc=info@xenosoft.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=madskateman@gmail.com \
    --cc=mkchauras@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=nnmlinux@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=rtd2@xtra.co.nz \
    --cc=sshegde@linux.ibm.com \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®