From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EFE279DAD for ; Thu, 16 Jul 2026 03:59:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784174401; cv=none; b=lICsB0WXc//+BZCqrxu5r5FD7OFW3OCluD6SpQdWRBabz05V17nPoqwQ5R5PCqyskPz36X91qzLQYyPUI4qs2j/gRv+q1xsJC7dCaCEhU9lODjtDYD40KVBFkuYIzmI87N7JBYGQ07g3zvYMJozT4YgFzkUbh7W3t9pXep6PC58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784174401; c=relaxed/simple; bh=HXAcv7zR9DZvOlAxZastOJZqx5We/qUHI3lXG7tA6hk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hFK7b7IY7G9H3rUUnsTJAnWAh5xttgfnWN+J0dyruR6C8VcRsBfd/dOHB6lu5zLN/dLjAJ6idNIE5GCyo2s+IL5aXe8noprelJwKTr09FpA/L2naUyp/f6/uVnOeiS2mplHsrB64b4BStwQYz5ldIGPB6grx5pmjhFdUlEJrv3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ggm7JrZ6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NhpDy3rH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ggm7JrZ6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NhpDy3rH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784174398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nmg9QF7g6+RGBqa8lAeiCv+Pq0crS7eN559cYymqtdM=; b=Ggm7JrZ6FfDF7O3nshZqkl7r9IuZ7bBd9z/1V8TniEhmsQyQlyDEBrSXk9KXrd6kmPeFDy YyHVFzpwN7ZX4l5EAdRwhcNt60g0Irtl0pGIYWGu8oQZ5qghDFgMaLc8+zLNYbplsKyOlh JyXuZzYXs3wFk2sTUYj5aHKfSLPw4FU= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-zT1knjj9MSeVIAVxxcIgpg-1; Wed, 15 Jul 2026 23:59:55 -0400 X-MC-Unique: zT1knjj9MSeVIAVxxcIgpg-1 X-Mimecast-MFC-AGG-ID: zT1knjj9MSeVIAVxxcIgpg_1784174394 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c860544c077so6710261a12.3 for ; Wed, 15 Jul 2026 20:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784174394; x=1784779194; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nmg9QF7g6+RGBqa8lAeiCv+Pq0crS7eN559cYymqtdM=; b=NhpDy3rH0heO/MDtxhx9Hk7PckaUDi4vxg4fwFlOFbdd06JywSrcwKqZH2nyNzOAJx 72OJgxF8D5PSbUBoDBxTBFRASwFNYtLcyIXKsPAoQ13CcovxOJc5n7IljBeig2rEFJaQ Z7qEBEu3JItvh76XO308T+oNyGg0dh0PfscyWn9QFflL4J6jLAjFwZd2cJoBwVvlGFzv mGD7wG8h0Wpr/RDGgPwVFczjtCMQ6And/xqY+Zx0gDM+dmYbKtW1sSpOrZwM5gYDtV7E eR17lEYLa5lbEg5rbQSHg/09WKgZS9Iy8R0KGeMJnDEGpg7oS6oQoDYWyu8Xznh6MBC+ IUaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784174394; x=1784779194; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nmg9QF7g6+RGBqa8lAeiCv+Pq0crS7eN559cYymqtdM=; b=c6zt20zCdlcUWedUEHuB2XyywaIJk1KYURW9b1jbIctT5MbmcjyeY8wk4jJuwVFJea 5NNhPDXzhIjx4XD1IPDvdtJDQHjRWThGi8q7WB+JOtr8UpiEQs3tu+y25pWIgTKh5WQG zkbfiIbEuhHABl1dqU97+f/mShHDk6IDuk5EyT25AN/LyXzcJisK49ZrKMsecRAZ9qVk AKgz9XsIT/hXh7ZDfj20x2RUKkx2Dm8KHW0NHPTDOGDE37QhfvbBk+MVPdk/r8nHEybw LBabSJwe4q7zHtqPxkXTiOiCry6qa/MKZs4KyDWIy2qEODlgyZ7yJnmdg8T+BMcgyBR+ yMhw== X-Forwarded-Encrypted: i=1; AHgh+RrdsFmue1jr9RUS5fv7ocuAK3koAPBp4O+Hasi5Bg3Tq9QQuN7roAegnd3TsIBhrWRMt6ZGb2HF1jrF9GI=@vger.kernel.org X-Gm-Message-State: AOJu0YyVzftvpqcilu6l0hthwDeXIaGlR+RSr28XMfADB9elZPA3H5va ApoV4v/gxKheJogLuN0kypRuUBN6SUcySYhh1dVZpPbnM3BFZYzBbAzVBUucGMPlLs0/FjrPmkc cuErWtBhu1NDRfqfXZ7mnoC8dCjhl0sEHuH4cPZ19lYR5lq6iz9s9lILl3Zj2Nsj8HyfQXJ4rnw == X-Gm-Gg: AfdE7clUXVfIagAqG+LEdLyPb80mBMN3NKXiEQrkqif2xNJoavDLtwBuZvKQKV3ael4 yrKnUYdxXpbf6sXsM5Hpeb4QMNy2+DlXPb7wgnM5/gLRmC6c1i99+j/OWRKuHnLEadHdoxppV3g cu/YKIozX5qfsIqgs9jUVFSXRJ8a97USkE3mQIYsmfDsIT9gCCC4DpR++4mTnJAG8MCHKAT1kTi 48udAhf2ZQE8P6Ua4ojfmbUXcN/3WxKvkHP19lPV/+lu8njoLHJguleMn3ahsoUjegRrlyDahKn LlvhS0eFfNuj671yVhzq2BBZcq1zr4UcmUj3eur/joc7Vgq9K+1Px800bonp6DPJETW9qCuj4U9 dLWkeHtOvSs4hdt4Wh159Zz7qnkcLhqf2nRFJfFZH3Xo= X-Received: by 2002:a05:6a21:2d44:b0:3b5:6b5a:4f29 with SMTP id adf61e73a8af0-3c1102a1727mr19496065637.30.1784174394507; Wed, 15 Jul 2026 20:59:54 -0700 (PDT) X-Received: by 2002:a05:6a21:2d44:b0:3b5:6b5a:4f29 with SMTP id adf61e73a8af0-3c1102a1727mr19496050637.30.1784174394071; Wed, 15 Jul 2026 20:59:54 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cd4365b0dsm10762330c88.15.2026.07.15.20.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 20:59:53 -0700 (PDT) Message-ID: <519cddd8-d67a-4aef-afdf-97c933b73f82@redhat.com> Date: Thu, 16 Jul 2026 13:59:48 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] arm_mpam: Restore the error interrupt enable from mpam_cpu_online() To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-3-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-3-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ben, On 7/10/26 9:55 PM, Ben Horgan wrote: > When all CPUs affine to an MSC are offline the MSC may lose register state > which the driver then restores when an affine CPU comes back online. The > error interrupt enable, MPAMF_ECR.INTEN, is missed. > > Restore MPAMF_ECR at CPU online. > > Fixes: 49aa621c4dca ("arm_mpam: Register and enable IRQs") > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 82966ca2a631..acfa9a4dc2fc 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -1852,8 +1852,14 @@ static int mpam_cpu_online(unsigned int cpu) > if (msc->reenable_error_ppi) > _enable_percpu_irq(&msc->reenable_error_ppi); > > - if (atomic_fetch_inc(&msc->online_refs) == 0) > + if (atomic_fetch_inc(&msc->online_refs) == 0) { > + mutex_lock(&msc->error_irq_lock); > + if (msc->error_irq_hw_enabled) > + mpam_touch_msc(msc, mpam_enable_msc_ecr, msc); > + mutex_unlock(&msc->error_irq_lock); > + > mpam_reprogram_msc(msc); > + } > } > I don't understand how this happened that MPAMF_ECR gets lost, but msc->error_irq_hw_enabled is kept as true. mpam_disable_msc_ecr() is triggered in __mpam_irq_handler() or mpam_unregister_irqs(). Both are related to mpam_broken_work, which is invoked to disable the driver completely. I don't see how MPAMF_ECR is cleared at CPU offline time. > if (mpam_resctrl_enabled) Thanks, Gavin