Re: [PATCH] arm64: dts: qcom: x1e80100-dell-xps13-9345: Disable PM8010

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 6/16/25 10:09 AM, Bryan O'Donoghue wrote:
> On 15/06/2025 19:29, Aleksandrs Vinarskis wrote:
>> Hi all,
>>
>>
>> Revisiting this change in context of Dell XPS 9345 and now Lenovo ThinkBook 16 [1] (and upcoming Lenovo Ideapad 5) as these do not have pm8010.
>>
>>
>> Perhaps safest and easiest is to simply disable pm8010 in `x1e80100- pmics.dtsi` as proposed and _not_ enable it on any devices, since its known to not be used anywhere _yet_? As its a camera PMIC, the only submitted upstream (did not land yet) change that utilizes pm8010 on X1/ X1E is Bryan's CAMSS series that enables camera on CRD [2]. There are a few other laptops that have patches to enable the camera (my Zenbook, Bryan's branch on Gitlab for few more laptops) but those were not submitted yet, so can be easily changed to explicitly enable pm8010 before submission. This way we could simplify this change and not have to figure out which of the upstream devices do in fact have pm8010 onboard.
> 
> As a general principle, unless its used it should be disabled.
> 
> pm8010 is a camera specific PMIC and Dell has its own way of powering the camera sensors on XPS, Inspiron and I'd guess other models too, presumably as a result of reusing the x86 design with Qcom with minimal changes.
> 
> Disable by default. +1

Sure, we can do that

Konrad