From: "Jan Beulich" <JBeulich@suse.com>
To: "David Vrabel" <david.vrabel@citrix.com>
Cc: "John Stultz" <john.stultz@linaro.org>, <xen-devel@lists.xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when the system time changes
Date: Wed, 29 May 2013 08:39:39 +0100 [thread overview]
Message-ID: <51A5CCDB02000078000D9798@nat28.tlf.novell.com> (raw)
In-Reply-To: <1369765368-10823-3-git-send-email-david.vrabel@citrix.com>
>>> On 28.05.13 at 20:22, David Vrabel <david.vrabel@citrix.com> wrote:
> +static int xen_pvclock_gtod_notify(struct notifier_block *nb, unsigned long unused,
> + void *priv)
> +{
> + static struct timespec last, next;
> + struct timespec now;
> + struct timekeeper *tk = priv;
> + struct xen_platform_op op;
> + int ret;
> +
> + /*
> + * Set the Xen wallclock from Linux system time.
> + *
> + * dom0 hasn't historically maintained a very accurate
> + * wallclock so guests don't expect it. We can therefore
> + * reduce the number of expensive hypercalls by only updating
> + * the wallclock every 0.5 s.
> + */
> +
> + now.tv_sec = tk->xtime_sec;
> + now.tv_nsec = tk->xtime_nsec >> tk->shift;
> +
> + if (timespec_compare(&now, &last) > 0
> + && timespec_compare(&now, &next) < 0)
Is this really working the first time through (when both last and
next are still all zeros)?
Jan
> + return 0;
> +
> op.cmd = XENPF_settime;
> - op.u.settime.secs = now->tv_sec;
> - op.u.settime.nsecs = now->tv_nsec;
> + op.u.settime.secs = now.tv_sec;
> + op.u.settime.nsecs = now.tv_nsec;
> op.u.settime.system_time = xen_clocksource_read();
>
> ret = HYPERVISOR_dom0_op(&op);
> if (ret)
> - return ret;
> + return 0;
>
> - /* Set the hardware RTC. */
> - return mach_set_rtc_mmss(now);
> + last = now;
> + next = timespec_add(now, ns_to_timespec(NSEC_PER_SEC / 2));
>
> + return 0;
> }
next prev parent reply other threads:[~2013-05-29 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 18:22 [PATCHv2 0/2] xen: maintain an accurate persistent clock in more cases David Vrabel
2013-05-28 18:22 ` [PATCH 1/2] x86/xen: sync the CMOS RTC as well as the Xen wallclock David Vrabel
2013-05-28 19:01 ` John Stultz
2013-05-28 19:05 ` Konrad Rzeszutek Wilk
2013-05-28 18:22 ` [PATCH 2/2] x86/xen: sync the wallclock when the system time changes David Vrabel
2013-05-28 18:53 ` John Stultz
2013-05-29 7:42 ` [Xen-devel] " Jan Beulich
2013-05-29 9:42 ` David Vrabel
2013-06-04 1:22 ` Marcelo Tosatti
2013-05-29 7:39 ` Jan Beulich [this message]
2013-05-29 9:48 ` [Xen-devel] " David Vrabel
2013-05-29 7:47 ` Jan Beulich
2013-05-29 9:37 ` David Vrabel
2013-05-29 19:58 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5CCDB02000078000D9798@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=john.stultz@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®