From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935153Ab3E2Hrh (ORCPT ); Wed, 29 May 2013 03:47:37 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:33975 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935106Ab3E2Hrg convert rfc822-to-8bit (ORCPT ); Wed, 29 May 2013 03:47:36 -0400 Message-Id: <51A5CEB402000078000D97BA@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.2 Date: Wed, 29 May 2013 08:47:32 +0100 From: "Jan Beulich" To: "David Vrabel" Cc: "John Stultz" , , "Konrad Rzeszutek Wilk" , Subject: Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when the system time changes References: <1369765368-10823-1-git-send-email-david.vrabel@citrix.com> <1369765368-10823-3-git-send-email-david.vrabel@citrix.com> In-Reply-To: <1369765368-10823-3-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 28.05.13 at 20:22, David Vrabel wrote: > @@ -199,28 +201,59 @@ static void xen_get_wallclock(struct timespec *now) > > static int xen_set_wallclock(const struct timespec *now) > { > - struct xen_platform_op op; > - int ret; > - > /* do nothing for domU */ > if (!xen_initial_domain()) > return -1; > > - /* Set the Xen wallclock. */ > + /* Set the hardware RTC. */ > + return mach_set_rtc_mmss(now); > + > +} Can't you achieve the same effect in a cleaner way by overriding x86_platform.set_wallclock only in the non-init-domain case? Jan