From: Stephen Warren <swarren@wwwdotorg.org>
To: J Keerthy <j-keerthy@ti.com>
Cc: b-cousson@ti.com, devicetree-discuss@lists.ozlabs.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
ldewangan@nvidia.com, grant.likely@secretlab.ca,
swarren@nvidia.com, sameo@linux.intel.com, gg@slimlogic.co.uk,
lee.jones@linaro.org
Subject: Re: [PATCH v3] ARM: dts: OMAP5: Add palmas MFD node and regulator nodes
Date: Tue, 11 Jun 2013 10:01:43 -0600 [thread overview]
Message-ID: <51B749E7.6070808@wwwdotorg.org> (raw)
In-Reply-To: <1370928651-6278-1-git-send-email-j-keerthy@ti.com>
On 06/10/2013 11:30 PM, J Keerthy wrote:
> This patch adds Palmas MFD node and the regulator nodes for OMAP5.
>
> The node definitions are based on: https://lkml.org/lkml/2013/6/6/25
>
> Boot tested on omap5-uevm board.
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> + palmas: palmas@48 {
> + reg = <0x48>;
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N */
> + interrupt-parent = <&gic>;
> + };
> +};
> +
> +&palmas {
> + compatible = "ti,palmas";
> + interrupt-controller;
> + #interrupt-cells = <2>;
I don't really see the point of splitting the node into two parts if
it's all going into a single file. It made sense if part of the node
came from a common .dtsi file, but not so much when it doesn't.
next prev parent reply other threads:[~2013-06-11 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 5:30 J Keerthy
2013-06-11 16:01 ` Stephen Warren [this message]
2013-06-12 8:12 ` J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B749E7.6070808@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=j-keerthy@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome