From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>,
Andrew Shewmaker <agshew@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Namjae Jeon <linkinjeon@gmail.com>,
Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] mm/writeback: fix wb_do_writeback exported unsafely
Date: Fri, 14 Jun 2013 17:38:45 +0800 [thread overview]
Message-ID: <51BAE4A5.6070506@cn.fujitsu.com> (raw)
In-Reply-To: <20130614093159.GB10084@dhcp22.suse.cz>
On 06/14/2013 05:31 PM, Michal Hocko wrote:
> On Fri 14-06-13 12:29:52, Kirill A. Shutemov wrote:
>> Michal Hocko wrote:
>>> On Fri 14-06-13 15:30:34, Wanpeng Li wrote:
>>>> There is just one caller in fs-writeback.c call wb_do_writeback and
>>>> current codes unnecessary export it in header file, this patch fix
>>>> it by changing wb_do_writeback to static function.
>>>
>>> So what?
>>>
>>> Besides that git grep wb_do_writeback tells that
>>> mm/backing-dev.c: wb_do_writeback(me, 0);
>>>
>>> Have you tested this at all?
>>
>> Commit 839a8e8 removes that.
>
> OK, I didn't check the most up-to-date tree. Sorry about this confusion.
> I do not object to cleanups like this but it should be clear they are
> cleanups. "fix wb_do_writeback exported unsafely" sounds like a fix
> rather than a cleanup
Agreed.
>
>>>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>>
>> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>
>> --
>> Kirill A. Shutemov
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
Thanks.
Zhang Yanfei
next prev parent reply other threads:[~2013-06-14 9:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 7:30 Wanpeng Li
2013-06-14 7:30 ` [PATCH 2/8] mm/writeback: remove wb_reason_name Wanpeng Li
2013-06-14 7:30 ` [PATCH 3/8] mm/writeback: Don't check force_wait to handle bdi->work_list Wanpeng Li
2013-06-14 7:30 ` [PATCH 4/8] mm/writeback: rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD Wanpeng Li
2013-06-14 17:57 ` Tejun Heo
2013-06-14 7:30 ` [PATCH 5/8] mm/page_alloc: fix blank in show_free_areas Wanpeng Li
2013-06-14 7:30 ` [PATCH 6/8] mm/page_alloc: fix doc for numa_zonelist_order Wanpeng Li
2013-06-14 7:30 ` [PATCH 7/8] mm/thp: fix doc for transparent huge zero page Wanpeng Li
2013-06-14 8:28 ` Kirill A. Shutemov
2013-06-14 7:30 ` [PATCH 8/8] mm/pgtable: Don't accumulate addr during pgd prepopulate pmd Wanpeng Li
2013-06-14 9:02 ` [PATCH 1/8] mm/writeback: fix wb_do_writeback exported unsafely Michal Hocko
2013-06-14 9:29 ` Kirill A. Shutemov
2013-06-14 9:31 ` Michal Hocko
2013-06-14 9:38 ` Zhang Yanfei [this message]
2013-06-14 9:31 ` Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BAE4A5.6070506@cn.fujitsu.com \
--to=zhangyanfei@cn.fujitsu.com \
--cc=agshew@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®