From: Yijing Wang <wangyijing@huawei.com>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Forest Bond <forest@alittletooquiet.net>,
Jiri Kosina <trivial@kernel.org>, <linux-kernel@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Devendra Naga <devendra.aaru@gmail.com>,
Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
Bill Pemberton <wfp5p@virginia.edu>,
LKML <linux-kernel@vger.kernel.org>,
Devendra Naga <devendra.aaru@gmail.com>,
Joe Perches <joe@perches.com>,
Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Subject: Re: [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros
Date: Tue, 2 Jul 2013 09:14:06 +0800 [thread overview]
Message-ID: <51D2295E.8010601@huawei.com> (raw)
In-Reply-To: <1372337843-24624-1-git-send-email-wangyijing@huawei.com>
ping...?
On 2013/6/27 20:57, Yijing Wang wrote:
> Use standard PM state macros PCI_Dx instead of numeric 0/1/2..
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: Forest Bond <forest@alittletooquiet.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Kosina <trivial@kernel.org>
> Cc: Devendra Naga <devendra.aaru@gmail.com>
> Cc :Joe Perches <joe@perches.com>
> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Cc: Bill Pemberton <wfp5p@virginia.edu>
> Cc: devel@driverdev.osuosl.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/staging/vt6655/device_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 08b250f..7f36a71 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -3370,8 +3370,8 @@ viawget_resume(struct pci_dev *pcid)
> PSMgmtObject pMgmt = pDevice->pMgmt;
> int power_status; // to silence the compiler
>
> - power_status = pci_set_power_state(pcid, 0);
> - power_status = pci_enable_wake(pcid, 0, 0);
> + power_status = pci_set_power_state(pcid, PCI_D0);
> + power_status = pci_enable_wake(pcid, PCI_D0, 0);
> pci_restore_state(pcid);
> if (netif_running(pDevice->dev)) {
> spin_lock_irq(&pDevice->lock);
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2013-07-02 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 12:57 Yijing Wang
2013-07-02 1:14 ` Yijing Wang [this message]
2013-07-02 1:23 ` Greg Kroah-Hartman
2013-07-02 1:35 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2295E.8010601@huawei.com \
--to=wangyijing@huawei.com \
--cc=devendra.aaru@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=trivial@kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome