From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754786Ab3GOJ4n (ORCPT ); Mon, 15 Jul 2013 05:56:43 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:53061 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754696Ab3GOJ4m (ORCPT ); Mon, 15 Jul 2013 05:56:42 -0400 Message-ID: <51E3C756.1080807@mev.co.uk> Date: Mon, 15 Jul 2013 10:56:38 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130701 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ian Abbott CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "oliver@schinagl.nl" , "linux@roeck-us.net" Subject: Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups References: <1373843160-3990-1-git-send-email-gregkh@linuxfoundation.org> <51E3C3E0.1050906@mev.co.uk> In-Reply-To: <51E3C3E0.1050906@mev.co.uk> Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013-07-15 10:41, Ian Abbott wrote: > On 2013-07-15 00:05, Greg Kroah-Hartman wrote: >> Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later. I >> considered it, but that would also mean a BUS_PATTR() and the like, which I >> guess works, but I hate even a _hint_ of "Hungarian" notation, which this >> implies. >> >> Anyone else have a better name for this macro: >> #define DEVICE_PATTR(_name) &dev_attr_##_name.attr >> that they can think of? It will cut down on the typing done for >> attribute lists. > > DEVICE_ATTR_P or DEV_ATTR_P to save typing. Or would that be confused > with the P convention[1]? If so, DEVICE_ATTR_PTR or DEV_ATTR_PTR could > be used. > > [1] see Jargon File. Then again, those follow the naming of DEVICE_ATTR_RO and DEVICE_ATTR_RW too closely. Time for someone else to do a bit of bike-shedding. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-