Winkler, Tomas wrote:
>>
>>
>>>
>>> This series should fix the long standing reset storm issue in mei
>>> suspend/resume failure
>>>
>
> Can you guys confirm these fixes the issue for you.
> Thanks
> Tomas

Nope, it's still broken

kernel: 3.10.2 + my patch for i915 + four your patches. config in attachment

I see endless flood in dmesg after several suspend-resume cycles

Jul 24 23:39:41 zurg kernel: [    1.737907] mei_me 0000:00:16.0: setting latency timer to 64
Jul 24 23:39:41 zurg kernel: [    1.738335] mei_me 0000:00:16.0: irq 47 for MSI/MSI-X
Jul 24 23:40:29 zurg kernel: [   47.040300] mei_me 0000:00:16.0: suspend
Jul 24 23:40:29 zurg kernel: [   47.759004] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:40:29 zurg kernel: [   47.859078] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:40:29 zurg kernel: [   47.859082] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:40:36 zurg kernel: [   54.846016] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:40:50 zurg kernel: [   64.161164] mei_me 0000:00:16.0: suspend
Jul 24 23:40:50 zurg kernel: [   64.881192] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:40:50 zurg kernel: [   64.981346] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:40:50 zurg kernel: [   64.981349] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:41:01 zurg kernel: [   69.163476] mei_me 0000:00:16.0: suspend
Jul 24 23:41:01 zurg kernel: [   71.968336] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:41:01 zurg kernel: [   72.220902] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:41:01 zurg kernel: [   72.321278] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:41:01 zurg kernel: [   72.321282] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:41:12 zurg kernel: [   76.497560] mei_me 0000:00:16.0: suspend
Jul 24 23:41:12 zurg kernel: [   79.308237] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:41:12 zurg kernel: [   79.561639] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:41:12 zurg kernel: [   79.661996] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:41:12 zurg kernel: [   79.661999] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:41:23 zurg kernel: [   86.052274] mei_me 0000:00:16.0: suspend
Jul 24 23:41:23 zurg kernel: [   86.648672] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:41:23 zurg kernel: [   86.902364] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:41:23 zurg kernel: [   87.001336] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:41:23 zurg kernel: [   87.001339] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:41:34 zurg kernel: [   91.183450] mei_me 0000:00:16.0: suspend
Jul 24 23:41:34 zurg kernel: [   93.989014] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:41:34 zurg kernel: [   94.243145] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:41:34 zurg kernel: [   94.342737] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:41:34 zurg kernel: [   94.342741] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:41:45 zurg kernel: [   98.395809] mei_me 0000:00:16.0: suspend
Jul 24 23:41:45 zurg kernel: [  101.330239] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:41:45 zurg kernel: [  101.582884] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:41:45 zurg kernel: [  101.682818] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:41:45 zurg kernel: [  101.682822] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:41:56 zurg kernel: [  105.746993] mei_me 0000:00:16.0: suspend
Jul 24 23:41:56 zurg kernel: [  108.670366] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:41:56 zurg kernel: [  108.924615] mei_me 0000:00:16.0: irq 46 for MSI/MSI-X
Jul 24 23:41:56 zurg kernel: [  109.024898] mei_me 0000:00:16.0: reset: properties response hbm wrong status.
Jul 24 23:41:56 zurg kernel: [  109.024901] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:03 zurg kernel: [  116.011631] mei_me 0000:00:16.0: wait hw ready failed. status = -110
Jul 24 23:42:33 zurg kernel: [  145.944986] mei_me 0000:00:16.0: reset: init clients timeout hbm_state = 1.
Jul 24 23:42:33 zurg kernel: [  145.944994] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.946641] mei_me 0000:00:16.0: reset: wrong host start response
Jul 24 23:42:33 zurg kernel: [  145.946654] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.950458] mei_me 0000:00:16.0: reset: unexpected enumeration response hbm.
Jul 24 23:42:33 zurg kernel: [  145.950475] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.951480] mei_me 0000:00:16.0: reset: wrong host start response
Jul 24 23:42:33 zurg kernel: [  145.951494] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.951517] mei_me 0000:00:16.0: reset: unexpected enumeration response hbm.
Jul 24 23:42:33 zurg kernel: [  145.951523] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.951703] mei_me 0000:00:16.0: reset: wrong host start response
Jul 24 23:42:33 zurg kernel: [  145.951710] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.952346] mei_me 0000:00:16.0: reset: unexpected enumeration response hbm.
Jul 24 23:42:33 zurg kernel: [  145.952360] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.952689] mei_me 0000:00:16.0: reset: wrong host start response
Jul 24 23:42:33 zurg kernel: [  145.952696] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
Jul 24 23:42:33 zurg kernel: [  145.952716] mei_me 0000:00:16.0: reset: unexpected enumeration response hbm.
Jul 24 23:42:33 zurg kernel: [  145.952721] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING


>
>>> The issue was reported in few places:
>>> https://lkml.org/lkml/2013/6/26/693
>>> https://lkml.org/lkml/2013/7/14/69
>>>
>>>
>>> Tomas Winkler (4):
>>>    mei: hbm: fix typo in error message
>>>    mei: me: fix reset state machine
>>>    mei: don't have to clean the state on power up
>>>    mei: me: fix waiting for hw ready
>>>
>>>   drivers/misc/mei/hbm.c   |  2 +-
>>>   drivers/misc/mei/hw-me.c | 14 ++++++++++----  drivers/misc/mei/init.c
>>> |  3
>>> ++-
>>>   3 files changed, 13 insertions(+), 6 deletions(-)
>>
>>
>> CC: Konstantin and Shuah
>>
>> Tomas