From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] relay: fix timer madness
Date: Wed, 31 Jul 2013 18:38:26 +0800 [thread overview]
Message-ID: <51F8E922.3070008@huawei.com> (raw)
In-Reply-To: <51F8E06C.1010408@huawei.com>
On 2013/7/31 18:01, zhangwei(Jovi) wrote:
> From: Ingo Molnar <mingo@elte.hu>
>
> When I'm using ktap script to tracing all event tracepoints by relay
> transport, without this patch, the system will hang in few seconds.
>
> I found the original patch discussion in 2007.
> http://marc.info/?l=linux-kernel&m=118544794717162&w=2
> (In that mail thread, the patch didn't fix that problem, but it fix
> the problem I encountered now)
>
> Changed from origina patch:
> - mod timer interval changed from jiffies+1 to HZ/10, as Ingo suggested.
> - mod timer interval changed from HZ/10 to jiffies + HZ/10, suggested
> by Dan Carpenter, since mod_timer() takes an offset for interval.
>
> Original patch changelog from Ingo in 2007:
>
> Remove timer calls (!!!) from deep within the tracing infrastructure.
> This was totally bogus code that can cause lockups and worse.
> Poll the buffer every 2 jiffies for now.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Eric Dumazet <edumazet@google.com>
> ---
Hi Andrew,
How about this patch? this version folded the suggestion from Ingo and Dan.
jovi
next prev parent reply other threads:[~2013-07-31 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 10:01 zhangwei(Jovi)
2013-07-31 10:38 ` zhangwei(Jovi) [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-20 7:37 zhangwei(Jovi)
2013-04-23 21:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8E922.3070008@huawei.com \
--to=jovi.zhangwei@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome